Repository navigation
Conversation
Replace the retired requests.kennethreitz.org domain in intersphinx_mapping with https://requests.readthedocs.io/en/stable/. The legacy domain now serves an invalid self-signed TLS certificate, causing sphinx-build -W to fail in CI docs presubmits.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Sphinx documentation configuration in packages/google-auth/docs/conf.py to point the requests intersphinx mapping to its stable Read the Docs URL instead of the deprecated Kenneth Reitz domain. There are no review comments to address, and the change is appropriate.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
The
docspresubmit session inpackages/google-authis failing across PRs that trigger core/handwritten CI (such as #18971 and #18976) because the retiredrequests.kennethreitz.orgdomain now serves an invalid self-signed TLS certificate, causingsphinx-build -Wto exit withSSLCertVerificationError.Summary of Changes
"requests"inintersphinx_mappinginpackages/google-auth/docs/conf.pyfromhttps://requests.kennethreitz.org/en/master/tohttps://requests.readthedocs.io/en/stable/.Verification
SSLCertVerificationErrorfailure onorigin/mainvianox -s docsinpackages/google-authand verifiednox -r -s docspasses with zero warnings after this change.