Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Revert "chore(librarian): onboard to librarian" - #1626

Closed
chandra-siri wants to merge 1 commit into
mainfrom
revert-1625-onboard-to-librarian
Closed

chandra-siri wants to merge 1 commit into
mainfrom
revert-1625-onboard-to-librarian

Conversation

@chandra-siri

Copy link
Copy Markdown
Collaborator

Reverts #1625

Reason: Looks like the above PR is creating failure in owlBot PostProcessor. I'm unable to pin point the root cause , however it's started happening since this PR. Hence reverting it. (will revert again if presubmit doesn't get fixed)

Errors.
https://screenshot.googleplex.com/9mGSgh9osmcCWKp and

https://screenshot.googleplex.com/AAH2CxSNsYwVFjJ

@parthea , We can discuss further via internal chat

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Nov 19, 2025
@chandra-siri chandra-siri added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2025
@chandra-siri
chandra-siri marked this pull request as ready for review November 19, 2025 09:54
@chandra-siri
chandra-siri requested a review from a team as a code owner November 19, 2025 09:54
@chandra-siri
chandra-siri requested review from a team, Pulkit0110 and m-strzelczyk November 19, 2025 09:54
@chandra-siri

Copy link
Copy Markdown
Collaborator Author

Hi @parthea ,

Found the root cause by looking at entrypoint.sh . It throws error because our noxfile doesn't have format session.( We use black)

I can think of two solutions to fix this

  • Use an alias for black , so that both nox -s blacken and nox -s format works. (I lean towards this)
  • ignore errors if format session not found. in owlbot_main

what's your thoughts ?

@parthea

parthea commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

This is working as intended. We are migrating off of owlbot but #1625 did not actually remove the owlbot configuration. I'll fix that.

@parthea parthea closed this Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants