Repository navigation
chore(ci): run toys ci under bash so the Windows leg tests again - #257
Merged
Merged
Conversation
On windows-latest the default run shell is pwsh, where "$VAR" reads an unset PowerShell variable instead of the environment variable. Since #252 moved the event values into env:, the Windows leg has passed empty --github-event-name/--github-event-payload values to toys ci, which then falls back to a local diff and tests nothing. Set shell: bash on the step. Linux and macOS already default to bash.
This was referenced Sep 25, 2026
Merged
Merged
quartzmo
approved these changes
Oct 6, 2026
quartzmo
left a comment
quartzmo
left a comment
Member
There was a problem hiding this comment.
LGTM. Like #36609, the Windows leg has not been testing, and once this PR merges, the next nightly should run this gem on Windows for the first time in a couple months.
It might be good to proactively kick off CI right after merging this PR, and triage any issues.
Member
Author
Ran it pre-merge; all ran and green: https://github.com/googleapis/ruby-spanner/actions/runs/37705404358/job/113078468487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#252 moved
${{ github.event_* }}(resolved by GitHub before the shell runs) intoenv:variables resolved by the step's shell. Because this step runs across a multi-OS matrix (ubuntu-latest,macos-latest,windows-latest), Linux/macOS default tobash($VAR) while Windows defaults topwsh($env:VAR). Onwindows-latest,"$GITHUB_EVENT_*"resolved as unset local PowerShell variables (""), causingtoys cito silently skip all tests (before vs. after).Since no single env-var syntax resolves in both
bashandpwsh, this setsshell: bashso"$GITHUB_EVENT_*"resolves across all matrix OSes.Companion PRs: googleapis/google-cloud-ruby#36609, googleapis/ruby-core-libraries#78, googleapis/common-protos-ruby#436.