Implement Tutorial v2 module - #3445
Open
nighca wants to merge 24 commits into
Open
Conversation
Ethanlita
added a commit
to Ethanlita/builder
that referenced
this pull request
Aug 24, 2026
The Tutorial lifecycle prototype (goplus#3445) reads the completion feedback from a feedback field, and the name also says what the value is. Align the wire shape before either side ships. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Ethanlita
added a commit
to Ethanlita/builder
that referenced
this pull request
Aug 24, 2026
The contract (tutorial-class-framework.go / module_TutorialFramework.ts)
declares completeWith(message); the earlier switch to a {feedback} wire
field (b3784e9) followed the goplus#3445 prototype instead of the contract.
The contract is the source of truth, so revert to the {content} shape
shared by the other presentation capabilities and name the parameter
message; the prototype side should align with the contract instead.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nighca
changed the title
nighca
marked this pull request as ready for review
August 26, 2026 12:22
nighca
commented
Aug 28, 2026
| }, | ||
| "copilotContext": "Help the learner understand stepTo without writing the solution for them. The goal is to move Lita to Mushroom.", | ||
| "inEditorRoute": "/simple/sprites/Lita" | ||
| "inEditorPath": "/simple/sprites/Lita" |
Collaborator
Author
There was a problem hiding this comment.
这个字段命名调整是为了跟现有的 editor 的路由参数名保持一致
| content: FileCollection; | ||
| }; | ||
| /** Current unsaved Playground Course content used to generate its Copilot context. */ | ||
| export type GeneratePlaygroundCourseCopilotContextParams = Pick< |
Collaborator
Author
There was a problem hiding this comment.
这些类型名调整是为了跟原来代码中相关的类型命名风格保持一致。
| type Course struct { | ||
| Editor Editor | ||
| onStart func() | ||
| done chan struct{} |
Collaborator
Author
There was a problem hiding this comment.
这边 class framework 的改动只是为了把我 mock 数据中的逻辑能跑起来，最终以 #3442 为准
| super.dispose() | ||
| } | ||
|
|
||
| private createFramework(): XGoFramework { |
Collaborator
Author
There was a problem hiding this comment.
这里应该是回头要改成调用 #3442 提供的 createTutorialFramework 的
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tutorialfacade that loads Course data and dispatches to Guided or Playground learning flowsGuidedTutorial, while Playground Courses are route-local sessionsCoursePlaygroundcomposition for its ownerless project,inEditorPath, editor providers, and learner-facing presentationDesign status
This PR establishes the intended overall shape and responsibility distribution of Tutorial v2; it is not an exploratory prototype. Some integrations remain intentionally narrow until their owning work lands:
showMessage,complete, andcompleteWith; it will consume the complete contract from Tutorial v2: Tutorial Class Framework #3417Follow-up refinement can improve these details without changing the module boundary introduced here.
Validation
vue-tsc --build --forceshowMessageis presentedgit diff --checkRefs #3419