Repository navigation
feat: expose upstream f2c version to CMake consumers - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/version.cin the selected and verifiedsrc.tgzF2C_UPSTREAM_VERSIONwhile preserving the repository release version inF2C_VERSION_STRINGRelated Issue
Closes #63
Verification
cmake -S . -B build -DNET_FETCH=ON -DBUILD_TESTING=ONcmake --build build --parallelctest --test-dir build --output-on-failure— 67/67 passedNET_FETCH=OFFand the pinned local archives — 67/67 passedexamples/cmakedownstream project — 2/2 passed in both normal and strict offline configurationssrc/version.c, a malformed declaration, and duplicate declarationsCMake 3.20.6 is not installed locally. The existing Ubuntu 22.04 CI job will exercise the minimum supported CMake version.
Impact
CMake consumers can inspect
F2C_UPSTREAM_VERSIONindependently ofF2C_VERSION_STRING. Package compatibility checks continue to use the repository release version. InternalLIBF77andLIBI77component dates are not exposed.Documentation
The README documents the two public version variables. CONTRIBUTING documents the required consistency checks for an upstream archive refresh.
Checklist