Skip to content

refactor(model): register recommenders - #1310

Open
zhangzhenghao wants to merge 1 commit into
gorse-io:masterfrom
zhangzhenghao:feat/model-registry
Open

refactor(model): register recommenders#1310
zhangzhenghao wants to merge 1 commit into
gorse-io:masterfrom
zhangzhenghao:feat/model-registry

Conversation

@zhangzhenghao

Copy link
Copy Markdown
Contributor

Summary

  • add registries for collaborative filtering and click-through-rate models
  • route model creation, model search, and model serialization/deserialization through registries
  • preserve existing model type/name/header compatibility for BPR, ALS, and FM/AFM

Tests

  • /usr/local/go/bin/go test ./model/cf ./model/ctr ./master ./worker

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.80734% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.48%. Comparing base (96527b3) to head (f201048).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
master/tasks.go 0.00% 16 Missing ⚠️
model/cf/model.go 82.50% 4 Missing and 3 partials ⚠️
model/ctr/model.go 81.08% 3 Missing and 4 partials ⚠️
model/ctr/fm.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   73.27%   73.48%   +0.21%     
==========================================
  Files          93       93              
  Lines       17969    18046      +77     
==========================================
+ Hits        13166    13261      +95     
+ Misses       3391     3378      -13     
+ Partials     1412     1407       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants