Use Modal async API to remove executor concurrency bottleneck#514
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remote.aio()APIWhy
ModalLauncher.run_submission()currently wraps blockingFunction.remote()inloop.run_in_executor(None, ...). Python sizes that shared default executor from the KernelBot host's CPU count, so the API host can silently cap Modal concurrency far belowBackgroundSubmissionManager.max_workersand the Modal workspace GPU quota.For example, an API container exposing three CPUs receives a seven-thread default executor. Even with 24 submission workers and a 50-GPU Modal allowance, only seven blocking calls can reach Modal at once; the rest wait locally in the executor.
Modal provides
remote.aio()specifically for asynchronous callers, so this change removes that accidental CPU-derived bottleneck.Benefits
Validation
uv run pytest tests/test_modal.py -m 'not integration' -q— 3 passed, 11 deselecteduv run ruff check src/libkernelbot/launchers/modal.py tests/test_modal.py— passedremote.aio()— 12 ranked submissions produced 24 T4 calls, all completed, with 20 peak remote containers