Skip to content

fix(renovate-approve): use latestReviews so the guard works with the app token #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tolzhabayev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(renovate-approve): use latestReviews so the guard works with the app token #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/renovate-approve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,15 @@ jobs:
fi
printf '%s\n' "$verdict"

reviews=$(gh pr view "$PR_NUMBER" --repo "$GITHUB_REPOSITORY" --json reviews)
changes_requested=$(jq '[.reviews[] | select(.state == "CHANGES_REQUESTED")] | length' <<<"$reviews")
bot_approved=$(jq '[.reviews[] | select((.author.login | startswith("grafana-plugins-platform-bot")) and .state == "APPROVED")] | length' <<<"$reviews")
# latestReviews, not reviews: `--json reviews` also asks GraphQL for
# reviews.nodes[].commit, which needs `contents: read`. The app token
# only carries `pull_requests: write`, so that query fails outright as
# soon as the PR has any review, including one a rebase dismissed.
# latestReviews leaves the commit field out and is the better question
# anyway: only a reviewer's current position should count here.
reviews=$(gh pr view "$PR_NUMBER" --repo "$GITHUB_REPOSITORY" --json latestReviews)
changes_requested=$(jq '[.latestReviews[] | select(.state == "CHANGES_REQUESTED")] | length' <<<"$reviews")
bot_approved=$(jq '[.latestReviews[] | select((.author.login | startswith("grafana-plugins-platform-bot")) and .state == "APPROVED")] | length' <<<"$reviews")

case "$verdict" in
"VERDICT: approve"*)
Expand Down
Loading