Repository navigation
feat!: Upgrade to Binaryen v133 - #299
Open
spotandjake wants to merge 4 commits into
Open
spotandjake wants to merge 4 commits into
spotandjake wants to merge 4 commits into
Conversation
spotandjake
added
the
Binaryen Upgrade
spotandjake
marked this pull request as ready for review
September 23, 2026 20:03
Full Diff: WebAssembly/binaryen@version_132...version_133 API Additions: * Passes.remove_empty_function_exports * Passes.tail_call * Type.exnref * Type.null_exnref * HeapType.exn * HeapType.noexn API Removals: * Passes.trap_mode_clamp * Passes.trap_mode_js Changes not made: * exception handling (brand new api not implemented yet) * BinaryenTryTable * BinaryenThrowRef * BinaryenTryTableGetBody * BinaryenTryTableSetBody * BinaryenTryTableGetNumCatches * BinaryenTryTableGetCatchTagAt * BinaryenTryTableSetCatchTagAt * BinaryenTryTableGetCatchDestAt * BinaryenTryTableSetCatchDestAt * BinaryenTryTableIsCatchRefAt * BinaryenTryTableSetCatchRefAt * BinaryenTryTableGetSentTypeAt * BinaryenTryTableAppendCatch * BinaryenTryTableInsertCatchAt * BinaryenTryTableRemoveCatchAt * BinaryenTryTableHasCatchAll * BinaryenThrowRefGetExnref * BinaryenThrowRefSetExnref * wait (new api, we should open an issue) * BinaryenStructWait * BinaryenWaitqueueNew * BinaryenWaitqueueNotify * BinaryenPublish * BinaryenStructWaitGetRef * BinaryenStructWaitSetRef * BinaryenStructWaitGetIndex * BinaryenStructWaitSetIndex * BinaryenStructWaitGetExpected * BinaryenStructWaitSetExpected * BinaryenStructWaitGetTimeout * BinaryenStructWaitSetTimeout * BinaryenStructWaitGetWaitqueue * BinaryenStructWaitSetWaitqueue * BinaryenWaitqueueNotifyGetWaitqueue * BinaryenWaitqueueNotifySetWaitqueue * BinaryenWaitqueueNotifyGetCount * BinaryenWaitqueueNotifySetCount * BinaryenPublishGetRef * BinaryenPublishSetRef * general apis (not handled by us) * BinaryenSideEffectSuspends Notes: * I changed the `HeapTypes` api to use the js api rather than the underlying binaryen calls, this is more inline with how we handle things elsewhere. (The only reason this wasn't done originally is the js api didn't originally support them). Grain Notes: * `addDefaultFunctionOptimizationPasses` was modified so we need to update our grain passes.
It seems the ci errors we were getting is because the underyling type of `BinaryenRefNull` changed to take a `HeapType` instead of a regular type however the c api wasn't updated.
…ndency resolutions, it seems like something changed in `ocp-indent`, it doesn't really matter because we don't use ocaml 6 anyways.
spotandjake
force-pushed
the
spotandjake/133
branch
from
October 13, 2026 19:14
5fa9e72 to
945be05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full Diff: WebAssembly/binaryen@version_132...version_133
API Additions:
API Removals:
Changes not made:
Notes:
HeapTypesapi to use the js api rather than the underlying binaryen calls, this is more inline with how we handle things elsewhere. (The only reason this wasn't done originally is the js api didn't originally support them).Grain Notes:
addDefaultFunctionOptimizationPasseswas modified so we need to update our grain passes.NOTE: I had to modify our ocaml constraints as it seems that ocaml
5.5.1released making our package want ocaml5.5.1whereasocp-identis only compatible up to ocaml5.5.0