Deprecate vscode-ext scaffolding - #66
Merged
Merged
Conversation
Newer Deno (2.x) changed setTimeout's return type from `number` to a branded `Timeout` type, breaking type-checking in the E2E job (TS2322). Annotate timer variables with `ReturnType<typeof setTimeout>` so they track the runtime's actual return type instead of asserting `number`.
Owner
Author
|
@eitsupi looks like our E2E CI workflows are hitting some (unrelated to this PR) Deno |
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates and removes the repository’s standalone VS Code extension scaffolding (vscode-ext/) and its associated release workflow, updating user-facing and package documentation to point to the upstream VS Code R extension integration.
Changes:
- Removes the in-repo VS Code extension implementation, tests, and packaging/config files under
vscode-ext/. - Removes the nightly VS Code extension release workflow.
- Updates top-level README and R package docs (roxygen + Rd + NEWS + DESCRIPTION metadata) to reflect the upstream VS Code R extension support.
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
vscode-ext/tsconfig.json |
Removes TS build configuration for the deprecated VS Code extension. |
vscode-ext/src/webview-provider.ts |
Removes webview renderer implementation for the deprecated extension. |
vscode-ext/src/socket-server.ts |
Removes Node socket server used by the deprecated extension. |
vscode-ext/src/socket-server.test.ts |
Removes tests for the deprecated extension socket server. |
vscode-ext/src/plot-history.ts |
Removes plot history implementation used only by the deprecated extension. |
vscode-ext/src/plot-history.test.ts |
Removes tests for the deprecated plot history module. |
vscode-ext/src/extension.ts |
Removes VS Code extension activation/commands implementation. |
vscode-ext/README.md |
Removes extension-specific README. |
vscode-ext/package.json |
Removes extension packaging metadata/scripts/dependencies. |
vscode-ext/LICENSE |
Removes extension-specific license file. |
vscode-ext/.vscodeignore |
Removes VS Code packaging ignore file. |
README.md |
Updates installation/usage docs to reference upstream VS Code R extension and retains Deno server option. |
r-pkg/R/jgd.R |
Updates roxygen docs describing supported frontends (VS Code via upstream extension + Deno server). |
r-pkg/NEWS.md |
Adds NEWS entry noting the upstream VS Code integration and doc updates. |
r-pkg/man/jgd.Rd |
Updates generated Rd to match the updated roxygen frontend documentation. |
r-pkg/man/jgd-package.Rd |
Updates generated package Rd author block (now includes maintainer email and author list change). |
r-pkg/DESCRIPTION |
Removes RoxygenNote and adds Config/roxygen2/version: 8.0.0. |
.gitignore |
Removes ignores specific to vscode-ext/ build artifacts; keeps ignoring *.vsix. |
.github/workflows/vsce-nightly-release.yml |
Removes the nightly VS Code extension packaging/release workflow. |
Files not reviewed (2)
- r-pkg/man/jgd-package.Rd: Generated file
- r-pkg/man/jgd.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
64
to
+66
| curl -fsSL \ | ||
| https://github.com/grantmcdermott/jgd/releases/download/nightly/jgd-vscode-nightly.vsix \ | ||
| -o jgd-vscode-nightly.vsix | ||
| code --install-extension jgd-vscode-nightly.vsix | ||
| https://github.com/REditorSupport/vscode-R/releases/download/latest/vscode-R.vsix \ | ||
| -o vscode-R.vsix |
Owner
Author
There was a problem hiding this comment.
Verified manually: the upstream repo has a release tagged literally latest (their rolling "Development Build" pre-release) carrying the vscode-R.vsix asset, so this command installs successfully as written. Switching to /releases/latest/download/ would resolve to the latest stable release (currently v2.8.8) instead of the 3.0.0-rc dev build we want, so keeping the URL as-is.
| ``` | ||
|
|
||
| Alternatively, you can also build and install the extension from source[^1]: | ||
| Once the 3.0.0-rc version of the extension has been installed, you will also |
| JSON, which it then passes on to a client that does the actual rendering (e.g., | ||
| a VS Code webview, a browser tab, or any future frontend). While this might | ||
| sounds like extra work, it turns out that it is both highly efficient and | ||
| generalizable (since JSON is so widely supported). Base R already provides most |
Address review feedback on PR #66: - Fix typos: "coversant"→"conversant" (x2), "automically"→"automatically", "maintence"→"maintenance", missing "it" and "might sounds"→"might sound" - Correct help topic "?jgd-spec"→"?jgd_spec" in the roadmap - Fix transposed upstream version "v0.3.0"→"v3.0.0" (extension reports 3.0.0-rc.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jgdVS Code functionality has now been absorbed by the main/upstream R extension: REditorSupport/vscode-R#1706