Repository navigation
fix(gfql): preserve quoted ORDER BY aliases - #2208
Merged
Merged
Conversation
lmeyerov
force-pushed
the
worker/fix-orderby-quoted-alias
branch
3 times, most recently
from
October 20, 2026 22:50
d3fbb51 to
5922f0a
Compare
lmeyerov
force-pushed
the
worker/fix-orderby-quoted-alias
branch
from
October 21, 2026 04:52
5922f0a to
ce0979f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identifierbefore aggregate-expression text mapping at both whole-key and nested boundaries.Boundary Matrix
(a.num + 1)output alias preserves arithmetic semantics for direct RETURN and explicit WITH re-aliasing; compound ORDER BY forms (+1, unary minus,abs, and genuinecount(*) + 1) preserve count/sum output bindings.v/`v`resolve to the projectedvoutput, not unrelated aggregate-expression text; genuinesum(w)and explicitgroup_valuecontrols retain independent ordering.ORDER BY \alias` * $factoraccepts supplied parameters and keeps opposite-ranking controls correct; missing parameters retain structuredmissing-required-fieldcontext (field=order_by,value=factor`).invalid-name-typecontext; genuine unprojected aggregates remain rejected across the row-column and MATCH+UNWIND paths.Evidence
bf2edb29822fad6b31f482c7203087325c92c7a1. The squashed rebase keeps thelowering.py, backtick tests, and CI-timeout blobs byte-identical;CHANGELOG.mddiffers only because master now contains the fix: preserve igraph collision attributes across round trips #2207 entry.ce0979f48fb66005f1539b3b06878b3543d0ef8a; treedf1286436ebdf8d77df7e430c6c0ea5108e32f6f. It includes accepted R10/R6 fromdb44b245…, R11 fromaa3a49a7…, accepted R12 at5275db6a…, and the P0051 test-only caller amendment.git diff --checkclean.graphistry/test-rapids-official:26.02-gfql, cuDF26.02.01): both new-caller cuDF nodes pass (2 passed, zero skips), and the full backtick suite is 220 passed. Whole-tree archive SHA-256:9494c7326c6acc960055abc0b6a597c05ae0f2f4d4dffe198d3baf630ae81415. Receipt:worker/research/round-003/S7-2208-rebase-ce0979f48.md.test-polars (3.12)checks. The superseded86ad494dCI run 39502035223 remains historical green evidence.db44b245…remains accepted: wave-7 24/24, host 163 passed/7 deselected, DGX full backtick suite 170 passed, CI run39454366281, and RTD build35274857.worker/research/round-002/S7-2205-r12-repair-5275db6a.md; prior R11/R10 receipts remain linked in the plan.Closes #2205