Repository navigation
fix(cugraph): isolate graph-return endpoint renames - #2214
Merged
Merged
Conversation
lmeyerov
force-pushed
the
worker/fix-cugraph-src-dst-collision
branch
from
October 21, 2026 17:38
6af8cc3 to
98aa401
Compare
lmeyerov
force-pushed
the
worker/fix-cugraph-src-dst-collision
branch
from
October 22, 2026 00:42
901515d to
4e6da0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/dstbindings.Fixes #2211
Evidence
Base:
origin/master@a3b3498ebe0d2b4f98d5f5d720a67e3d27fb58fe(fix(gexf): preserve endpoint attributes on import #2213 merge)Head:
05f841c9676a3b0ba8552dc63923ba14f1e20b74/ tree0f74a5e8b263e94954f98c23b68d2641f364ad42DGX red baseline:
src,dst, and both reproduceValueError: Duplicate column names are not allowed; clean,source,target, and generated-name controls pass.F5 red: original user attr
__cugraph_returned_edge_id__reproducesKeyErrorat30a493160c8d8c324627012740acddec7683ee49.Topology red: triangle plus tail,
k_core(k=2)retained 4 edges and warned about mismatched edge-table lengths before this fix.Topology fix:
out1andout2retain exactly the 3 triangle edges; retained labels survive, including reversed undirected orientations.Pandas matrix: 14 passed, 4 skipped, 23 deselected; Ruff clean.
Directed scope: cuGraph 26.02
ego_graph(directed=True)retains both orientations with exact attrs; one-sided conflicting undirected output is rejected.DGX final matrix: RAPIDS
graphistry/test-rapids-official:26.02-gfql, cuGraph26.02.00, cuDF26.02.01; focused tests19 passed, 23 deselected, 3 subtests passedat the exact head. Receipts:plans/mcp-next-2211-2212-1955/worker/receipts/step11-p0035-dgx-05f841c9.txtandplans/mcp-next-2211-2212-1955/worker/receipts/final-2214-hosted-gates-05f841c9.txt.The full DGX class has three failures at unchanged
059e2ac53and at this head: two 26.02from_cugraphexpectations andbatched_ego_graphsavailability. They are unchanged and outside the focused review scope.Changed-line coverage now includes
graphistry/plugins/cugraph.py; focused cuGraph coverage remains DGX-native.Review response: duplicate
(source, destination)pairs are explicitly rejected; retained output rows preserve one-to-one attribute identity; filtered topology is not restored.Final exact-head gates: CI run
39704024422SUCCESS, CodeQL run39704024437SUCCESS, and RTD build35313393SUCCESS. Receipt:plans/mcp-next-2211-2212-1955/worker/receipts/final-2214-hosted-gates-05f841c9.txt.P0035 directed graph-return durability
TEST_CUGRAPHregressiontest_graph_return_directed_ego_preserves_antiparallel_attrsthrough publiccompute_cugraph("ego_graph", directed=True); expects both orientations with distinct attrs.