Skip to content

fix(gfql): preserve scalar reentry across continuation matches - #2253

Open
lmeyerov wants to merge 9 commits into
masterfrom
fix/gfql-2252-scalar-carry
Open

lmeyerov wants to merge 9 commits into
masterfrom
fix/gfql-2252-scalar-carry

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Preserve engine-aware row-prefix slicing so pandas does not scalarize whole-node reentry prefixes.
  • Correlate hidden WITH-scalar carries through each surviving Polars edge step, including multi-edge paths and forward/reverse/undirected traversal.
  • Exempt valid hidden reentry property access from destination-alias masking and fix Polars empty-prefix handling.
  • Add pandas/Polars positive, empty-negative, multi-edge, multiplicity, no-reentry, and typed scalar coverage.
  • Add direct cuDF convergent positive and partial edge-filter rejection coverage.

Closes #2252.

Validation

  • Focused non-cuDF issue_2252 or issue_1413 or reentry selection: 141 passed.
  • Focused cuDF-only local runtime guard: 1 skipped (cudaErrorNoDevice).
  • DGX 26.02 exact-source focused cuDF test: admitted under 8 GiB RMM guard, then skipped. Diagnostic failed allocating 24 bytes (std::bad_alloc); contemporaneous foreign VLLM::EngineCore held 60,103 MiB. Recorded as unavailable, not parity or a product regression.
  • Ruff: passed. Type-hygiene guard: 4,439 grandfathered findings, no growth. Comment guard: passed. Source-pinned repro: passed.
  • Exact-head CI run: 40484557526, terminal SUCCESS. CodeQL run: 40484557483, terminal SUCCESS. RTD commit status: SUCCESS.

Identity

  • Base: d53fba85532949fd8881d6cb8079ebbdf17cb111
  • Head: cb2f6e0d0f9509c677f2b1fd8e6731fb5de980e3
  • Tree: 0280263441ea48e18cfb869a807fc84025b946b1
  • DGX receipt: plans/gfql-mcp-quality-2026-10-22/worker/receipts/p0705-dgx-cudf-cb2f6e0d0.md

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFQL Cypher: scalar carried through WITH reentry becomes None in grouped aggregates

1 participant