Encode query parameters regardless of the browser

[phyllipy]

Problem: Query parameters are not being encoded as expected

value: this&that

Browser: Firefox 93.0 (64-bit) Mac OS Big Sur

Google Chrome 94.0.4606.81 (Official Build) (x86_64) (Big Sur)

Solution: Update the parameterize helper to always encode the parameters (unless it is already encoded)

original issue: #103

[gstark]

I have this same issue and would love to see this PR land. However, I wonder if the test of value.indexOf("%") is too simplistic.

MDN gives this method for determining if a string contains encoded components.

function containsEncodedComponents(x) {
  // ie ?,=,&,/ etc
  return (decodeURI(x) !== decodeURIComponent(x));
}

We may also want to add a try/catch for URIError and assume false?

// From: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURIComponent
//
// Determines if a string already has encoded elements
export function containsEncodedComponents(stringToTest: string) {
  try {
    // ie ?,=,&,/ etc
    return decodeURI(stringToTest) !== decodeURIComponent(stringToTest)
  } catch (URIError) {
    return false
  }
}

[phyllipy]

I have this same issue and would love to see this PR land. However, I wonder if the test of value.indexOf("%") is too simplistic.

MDN gives this method for determining if a string contains encoded components.

function containsEncodedComponents(x) {
  // ie ?,=,&,/ etc
  return (decodeURI(x) !== decodeURIComponent(x));
}

We may also want to add a try/catch for URIError and assume false?

// From: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURIComponent
//
// Determines if a string already has encoded elements
export function containsEncodedComponents(stringToTest: string) {
  try {
    // ie ?,=,&,/ etc
    return decodeURI(stringToTest) !== decodeURIComponent(stringToTest)
  } catch (URIError) {
    return false
  }
}

Yeah I agree using value.indexOf("%") is a rather naive approach. However, the snippet above doesn't really work in all cases. For example, using comparing the string: http://example.com/api/v1/people?filter[name]=%22Jane%22 (used in one of the tests) we have:

value = "http://example.com/api/v1/people?filter[name]=%22Jane%22"
decodeURIComponent(value)   // =>  "http://example.com/api/v1/people?filter[name]=\"Jane\""
decodeURL(value)  // => "http://example.com/api/v1/people?filter[name]=\"Jane\"" 
decodeURI(value) !== decodeURIComponent(value)  // => false

This would result in a double encoding. But we can use decodeURI(value) and compare it with the original string, if equals then the string is not enconded.

value = "http://example.com/api/v1/people?filter[name]=%22Jane%22"

decodeURI(value) === value  // =>  false

[zailleh]

@phyllipy I suspect you don't want to have commited package-lock.json here