Repository navigation
Conversation
Author
|
@al-alsace /review |
PR Reviewer Guide 🔍(Review updated until commit d260d09)Here are some key observations to aid the review process:
|
Author
|
@graydovee 你看看有没有问题 |
|
Persistent review updated to latest commit d260d09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
给 chrome 插件添加 UI 语言切换选项，允许用户自己选择浏览器插件的UI语言
动机 / Motivation
当前浏览器插件的语言是随chrome语言设置联动的没法自己设置，英文的chrome没法选择插件UI显示中文
改动内容 / Changes
给插件的设置页面添加了一个语言选项
测试 / Testing
pnpm run build构建 chrome 扩展后在 chrome 浏览器验证过，语言选择功能正常
影响范围 / Impact
全平台
Checklist
pnpm run build/bash -n scripts/install.sh等基础检查 / Passed basic checks