freebsd build - #2285
Open
bim9262 wants to merge 1 commit into
Open
Conversation
Collaborator
|
The only worry I have is if no one steps up to help maintain it but if it's not that much burden for us to have those flags then maybe its ok for now. Are you running freebsd daily or was it just for testing this? |
Collaborator
Author
|
My thought is that this should be little maintenance. If you create a new block and it fails the CI you can just throw the linux only flag on it. If a FreeBSD user wants the block they can work on making it compatible with both (again has to pass the CI). I am not a daily user of FreeBSD and therefore may have over excluded some blocks that would work, but just need the right packages to be installed in the CI. |
Collaborator
Author
|
@hasufell feel free to test this out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hasufell
I ended up making an attempt to make i3status-rust work on FreeBSD.
The two main differences that this introduced is that it doesn't seem like FreeBSD allows for the custom signals used on linux and some of the blocks/dependencies aren't compatible with FreeBSD.
Note that if a block failed, I disabled it entirely instead of going through each one and determining if it was only a certain driver/backend/service that needed to be disabled on non-linux systems. It's also possible that I wasn't able to build some of the features like notmuch or pipewire because I am missing a system library. If that's the case we can update the
pkg installline to not need to fence off as many features.@ammgws, any thoughts on adding this in and allowing folks to improve what's available to non-linux systems down the line? I wouldn't think that there's any non
target_os = "linux"users today that this would impact.