Repository navigation
fix: guard the paths that remove or overwrite - #58
Merged
Merged
Conversation
- Install: a new instance needs a free name (no system account or service, nothing on the host under it); Ctrl+C or cancel at the confirmation runs nothing; a failure while applying previews the undo of what that run made and asks first. A pre-existing data dir or role is kept. - Purge: databases by owner or exact name only, superuser roles refused, databases dropped before their filestores, a shared data dir loses only the selected filestores, a role another instance uses is kept, the Linux user goes only when the tool made it, logrotate policy removed. - /var/log/odoo is root's; each instance owns its log, earlier logs get their owner back, logrotate policies lose su. - Delete: owner-checked dropdb before the config goes, data dir from both config locations, nginx reloaded only if installed, logrotate policy removed. - Copies: scoped chown, existing target filestore moved aside, copy into the target after checking the source, REPLACE <target> for a refresh, the data dir of the config being built wins. - Backups: dedicated directories only; retention by name; valid database names from file names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second audit, group A: the paths that remove or overwrite. Each fix is checked by running it (
tools/verify_data_safety.py).chown -R /var/log/odooon every install. The directory is now root's, each instance owns its own log, and logrotate no longer usessu.REPLACE <target>, and a replica's filestore goes to its configured data dir.OpenSpec:
2026-10-08-guard-destructive-paths(7 specs).Assisted-by: Claude