Repository navigation
fix: copies done whole and neutralised as Odoo does - #60
Merged
Merged
Conversation
- Each copy (refresh, replica, duplicate database, local restore) is one staged step: seed, identity, Odoo's own neutralize.sql, the catalogue, the check and the hand-over; a failure drops only the database the step created. A staging comment marks it until the hand-over, and a leftover of an interrupted run is replaced instead of refused. - The role gets CONNECT only at the hand-over (an Odoo with db_name set connects by name); CREATE on public is taken from PUBLIC. - A local restore goes as a duplication (no service stop); a remote one creates, restores and neutralises in one step that drops the database and restarts the service on failure; --no-comments; the service starts after the files. - On 16.0-19.0 every installed module's data/neutralize.sql runs first, read from the checkout as the instance user, run as the owner. - Catalogue, checked against Odoo 14.0-19.0 and OCA l10n-spain: delete rules, optional labels, Spanish EDI per version, VERI*FACTU and TicketBAI (Odoo and OCA), EDI proxy (14-16 parameter, MY/GR), web push, cloud storage, certificates, SMS, calendars per table, IAP long tokens, mail host pointed nowhere, a login sink, cli and EDI checks, citations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second audit, group C: restores, duplications and their neutralisation. The catalogue was checked against the Odoo 14.0–19.0 and OCA l10n-spain sources.
neutralize.sql→ catalogue → check → hand-over as a single step.CONNECTonly at the hand-over. Before, an Odoo withdb_nameset could connect by name.--no-comments, and the service starts after the files.neutralize.sql. It is read from the checkout as the instance user and run as the copy's owner.climail servers, and archived servers that 12–15 still use;Verified:
verify_privilege(CI) checks the staged copy: success, failure partway, an existing target, and a leftover.verify_neutralisationpasses with real Odoo 14 and 18. It covers Odoo's own SQL, the EDI demo parameter armed asprod, and the web push key.verify_data_safety,verify_secrets, unit tests, and openspec 1.4.1 all pass.OpenSpec:
2026-10-08-copies-done-whole.Assisted-by: Claude