fix: preserve full Groq response schemas in evals - #365
Open
cwilmott-groq wants to merge 3 commits into
Open
Conversation
cwilmott-groq
requested review from
BetterWithBeyti and
andrewtlw
as code owners
August 23, 2026 04:16
Registers an exact RFC 3339 full-time format checker: without the rfc3339-validator extra, python-jsonschema's built-in "time" checker mis-rejects valid values like "10:00:00Z" and "21:00:00.000Z", which produced the two false-positive schema_leak results in the 2026-08-26 production run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The first pass accepted any ss=60; mirror the API validator (santhosh-tekuri isTime) instead: a leap second is only valid when the offset-normalized time is 23:59 UTC. Add permanent accept/reject regressions for the checker. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Inspect previously discarded assertions before inference while the scorer retained them, creating false constrained-decoding failures. This change makes the sent schema and scored schema agree.
Validation