Repository navigation
fix: patch image dependencies and enforce Trivy severity - #2409
Draft
groupthinking wants to merge 5 commits into
Draft
groupthinking wants to merge 5 commits into
groupthinking wants to merge 5 commits into
Conversation
Bumps [source-map-js](https://github.com/7rulnik/source-map-js) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/7rulnik/source-map-js/releases) - [Changelog](https://github.com/7rulnik/source-map-js/blob/main/CHANGELOG.md) - [Commits](7rulnik/source-map-js@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: source-map-js dependency-version: 1.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [proxy-addr](https://github.com/jshttp/proxy-addr) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/jshttp/proxy-addr/releases) - [Changelog](https://github.com/jshttp/proxy-addr/blob/master/HISTORY.md) - [Commits](jshttp/proxy-addr@v2.0.7...v2.0.8) --- updated-dependencies: - dependency-name: proxy-addr dependency-version: 2.0.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
ci/cd
documentation
Contributor
Dependency ReviewThe following issues were found:
License Issuesrequirements.txt
docs/knowledge_prototypes/universal-automation-service/requirements.txt
docs/knowledge_prototypes/mcp-servers/mcp-alexnet/requirements.txt
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
🔍 PR Validation |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This was referenced Oct 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Closes #2425
Refs #2396
Linear: GRV-807
Outcome
Remediate the patchable application dependencies confirmed in the retained image scan, and make the root image's Trivy result a blocking HIGH/CRITICAL findings gate. This is partial remediation: the current Debian/npm/pip backlog remains unresolved, so this PR does not establish a clean image, production remediation, or deployment.
Current head:
1d9f72d7c40bff34aa43b8107cb817ad01e8efd5.Exact current-head scan evidence
Security Scan run 38258616455 / job 114843053097 scanned source
1d9f72d7c40bff34aa43b8107cb817ad01e8efd5and image IDsha256:3e479db974698dc0bf11eec7fbce12acee901a33fe8179570fe4418a6b2ec34e, created 2026-10-12T13:53:16Z for linux/amd64.Retained artifact
trivy-image-evidence:11751896119sha256:545f1565a67c41fe5a9d641854e74f28bbb7050aa3247e537ca27d4fcb976459image-source-commit.txt,image-identity.json,trivy-results.sarifThe SARIF contains 259 HIGH/CRITICAL occurrences across 68 unique advisories:
This is 15 fewer HIGH/CRITICAL occurrences than the exact prior-head image (274). The enforcing lowercase
trivyjob failed as designed. The uppercaseTrivySARIF-ingestion check succeeded because it found no new code-scanning alert in the PR diff; it does not override the findings gate.Verified corrections
These no longer appear in the exact current-head image report:
proxy-addr2.0.7 -> 2.0.8, production path Workflow ->@workflow/web-> Expresssource-map-js1.2.1 -> 1.2.2, production path Next -> PostCSSdevalue5.9.2 -> 5.9.3 under@workflow/coreThe reconciliation commit has PR #2353 and PR #2358 as parents, incorporating their exact dependency changes without merging their stale branch trees.
Implementation:
package-lock.jsonurllib3>=2.8.0application constraintsetuptools>=80.10.2andwheel>=0.46.2; 78.1.1 still carried flagged vendor metadata, so that lower floor was rejectedsite-packagesmetadata before copying the constrained environmentexit-code: 1,ignore-unfixed: false, retained identity/source/SARIF evidence, and a regular comment-only.github/trivy-no-exceptions.txtEvery remaining non-OS finding
/usr/lib/node_modules/npm/node_modules/brace-expansion/package.json/usr/lib/node_modules/npm/node_modules/http-cache-semantics/package.json/usr/lib/node_modules/npm/node_modules/undici/package.json/usr/local/lib/python3.11/site-packages/pip/_vendor/msgpack/usr/local/lib/python3.11/site-packages/pip/_vendor/setuptools/usr/local/lib/python3.11/site-packages/pip/_vendor/urllib3The Python filesystem paths are established by the exact version match to the latest pip 26.2.1 wheel's
pip/_vendor/vendor.txtand source tree; Trivy labels these four only asPython. Normal requirements constraints cannot replace pip's private vendor bundle.npm 12.2.0 and pip 26.2.1 are the current published releases inspected on 2026-10-12. npm has an open Priority 1 bug (#10062) confirming its current brace-expansion and undici copies are bundled, downstream overrides/audit fixes cannot replace them, and a refreshed npm release is required. pip 26.2.1 itself vendors msgpack 1.1.2, setuptools 70.3.0, and urllib3 2.7.0.
npm/npx remain runtime-reachable through optional build-validation and NotebookLM paths. pip remains reachable through the repository's CLI installation command and copied utility scripts. Removing either tool would change runtime behavior and is not treated as an incidental security update.
Remaining OS findings
The exact report has 251 OS occurrences across 61 unique advisories, with no fixed version populated. Representative authoritative Debian tracking confirms:
ffmpeg/ffprobe are part of readiness and yt-dlp runtime behavior. curl is the container healthcheck. gnupg/dirmngr support NodeSource installation but remain in the runtime layer today. Removing packages or changing the base image needs an isolated compatibility/build investigation; no OS finding is dismissed.
Verification
Local:
npm ci --legacy-peer-deps: passed (1,010 packages)npm run test --workspace=apps/web: 169 files / 1,495 tests passed; 28 skippednpm run type-check --workspace=apps/web: passedpython -m unittest tests.unit.test_merge_policy_security_scan_wording: 4 passedgit diff --check: passedCurrent-head hosted:
build, frontend/Python tests and lint, guards: passedtrivy: failed on 259 unresolved occurrences, as policy requiresMerge gates
No Trivy exceptions are applied. Future exceptions require separately reviewed package/version/image scope, applicability evidence, compensating controls, owner, linked issue, expiry, and enforced expiry validation.
Ruleset 24057160 requires a Closing keyword to an open issue; this body closes bounded child #2425 and references parent backlog #2396 without closing it. The classic branch-protection endpoint returns 403 to the GitHub App, so complete protection verification remains blocked. PR remains draft and unmerged.