Skip to content

fix(ci): skip preview lookup for non-deploying PRs - #2412

Merged
groupthinking merged 2 commits into
mainfrom
fix/e2e-preview-skip-unaffected-2411
Oct 12, 2026
Merged

groupthinking merged 2 commits into
mainfrom
fix/e2e-preview-skip-unaffected-2411

Conversation

@groupthinking

@groupthinking groupthinking commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • define EventRelay's Vercel deployment inputs in one reviewed manifest
  • classify every PR file, including previous paths for renames, before waiting for a preview
  • fail closed and require a preview if GitHub's capped PR file listing is incomplete
  • keep exact-preview E2E fail-closed for deployable changes while reporting non-deploying PRs as not applicable
  • preserve the full live E2E suite for pushes to main

A not-applicable result means no PR-specific deployment exists to probe; it is intentionally distinct from ALL TESTS PASSED.

Paths changed

  • .github/e2e-deployment-inputs.json
  • .github/workflows/e2e-tests.yml
  • tests/unit/test_workflow_pr_gate_coverage.py

Validation

  • UV_CACHE_DIR=/tmp/eventrelay-uv-cache uv run --with pytest --with pyyaml pytest -o addopts='' tests/unit/test_workflow_pr_gate_coverage.py -q — 36 passed
  • extracted actions/github-script body compiled successfully as an async function
  • git diff --check — passed
  • PR feat(security): validate offline MCP catalog approval pins #2408's six non-deployment paths classify needs_preview=false
  • apps/web/src/app/page.tsx and package-lock.json classify needs_preview=true
  • an incomplete one-of-3,001 path listing classifies needs_preview=true

Closes #2411

Copilot AI balanced review requested due to automatic review settings October 12, 2026 15:29
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: groupthinking/EventRelay/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: dafdf6c2-da34-4b70-8870-f4820c938a3e

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The classifier can miss deployment inputs when GitHub truncates PR file listings beyond 3,000 files.

1 open finding
What changed in this PR

Classifies PRs by Vercel deployment impact so live E2E only waits for relevant previews.

Changes:

  • Adds a reviewed deployment-input manifest.
  • Gates preview lookup and E2E execution on deployment impact.
  • Adds regression coverage for classification and workflow conditions.
File Description
.github/​e2e-deployment-inputs.json Defines Vercel deployment paths.
.github/​workflows/​e2e-tests.yml Classifies PR changes and records non-applicable runs.
tests/​unit/​test_workflow_pr_gate_coverage.py Tests classifier paths and workflow conditions.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/e2e-tests.yml Outdated
@groupthinking
groupthinking merged commit 33a3a47 into main Oct 12, 2026
27 checks passed
@groupthinking
groupthinking deleted the fix/e2e-preview-skip-unaffected-2411 branch October 12, 2026 15:43
@linear-code

linear-code Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

GRV-812

@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Oct 12, 2026 4:04pm UTC

This branch was successfully deployed

1 active deployment
Preview — 363aebc8 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: classify non-deploying PRs before waiting for a Vercel preview

2 participants