Repository navigation
Tab title with slide position - #193
Open
grunion-ai wants to merge 1 commit into
Open
grunion-ai wants to merge 1 commit into
grunion-ai wants to merge 1 commit into
Conversation
The tab read the deck title alone, so several open decks looked the
same and none said which slide was up. render() now writes
"<title> · slide 3 of 12" ("page" in a document format); a one-slide
deck keeps the bare name.
The PDF and the saved copy read deckName() where they read
document.title, so their filenames stay the bare deck name.
deck.html and library.html are rebuilt from the changed engine.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The browser tab now reads the deck title followed by the slide position, for example
Q3 update · slide 3 of 12. Before this, every tab showed the deck title alone, so several open decks looked identical and none said which slide was up.render()writesdocument.title, so the tab follows the arrow keys, the contact sheet and undo.Letter · page 1 of 2.deckName()where they readdocument.title, so both filenames stay the bare deck name.deck.htmlandlibrary.htmlare rebuilt from the changed engine.library-speaker.htmlandlibrary-reading.htmlhave no build script and keep the old tab title.Verification
test/gate.test.mjs: three-slide deck, title checked on slides 1, 2 and 3, PDF download namedTwo deals, one re-read.pdf, two-page letter titledLetter · page 1 of 2. It failed before the engine change and passes after.deckName()and neither readsdocument.title.Known limit
A tab narrower than about 180px truncates the count on a long title. The count sits after the title by request.
🤖 Generated with Claude Code