Skip to content

catch SecurityException on media URI access in the share flow #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
munzzyy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

catch SecurityException on media URI access in the share flow #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/src/main/java/org/witness/proofmode/share/ShareProofActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ class ShareProofActivity : AppCompatActivity() {
generateProof(mediaUri, proofHash, mimeType!!)
} catch (fe: FileNotFoundException) {
proofHash = null
} catch (se: SecurityException) {
proofHash = null
}
}
}
Expand Down Expand Up @@ -1175,6 +1177,8 @@ class ShareProofActivity : AppCompatActivity() {
)
} catch (fe: FileNotFoundException) {
Timber.d("FileNotFound: %s", mediaUri)
} catch (se: SecurityException) {
Timber.d("no access to media URI: %s", mediaUri)
}
}

Expand All @@ -1196,6 +1200,13 @@ class ShareProofActivity : AppCompatActivity() {
} catch (e: FileNotFoundException) {
Timber.w(e)
null
} catch (e: SecurityException) {
// The URI's read grant can be gone by the time we get here (e.g. a
// MediaStore URI shared from another app whose temporary permission
// already expired). Treat it the same as "no proof yet" instead of
// crashing the share screen.
Timber.w(e, "no access to media URI: %s", mediaUri)
null
}
}

Expand Down