Include function-argument fields in greedy '*' parameter load - #5401
Merged
Conversation
ahnitz
force-pushed
the
fix-star-excludes-function-args
branch
from
August 11, 2026 20:51
0116f3d to
a8b7159
Compare
When '--parameters' is given a function of fields together with '*', e.g. "'mchirp_from_mass1_q(mass1, q)' '*'", the greedy wildcard previously excluded every field that appeared as an argument to a function (here mass1 and q), because the exclusion set was built from FieldArray.parse_parameters, which returns the fields *needed to evaluate* the requested expressions. Only parameters requested explicitly as their own output column (i.e. given as a bare field name) should be excluded from the wildcard, so that fields used only as function arguments are still loaded. Update the help text accordingly.
ahnitz
force-pushed
the
fix-star-excludes-function-args
branch
from
August 11, 2026 21:55
a8b7159 to
c48d063
Compare
Member
Author
|
The initial failure looked like a network timeout (at least for the basic tests) so I'm rerunning |
cdcapano
approved these changes
Aug 19, 2026
cdcapano
left a comment
cdcapano
left a comment
Contributor
There was a problem hiding this comment.
We did this in group meeting together with Claude. Looks good. I think there might be some documentation that needs to be updated in the tutorials repo for this, but strictly speaking this doesn't break that, so approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When '--parameters' is given a function of fields together with '', e.g. "'mchirp_from_mass1_q(mass1, q)' ''", the greedy wildcard previously excluded every field that appeared as an argument to a function (here mass1 and q), because the exclusion set was built from FieldArray.parse_parameters, which returns the fields needed to evaluate the requested expressions.
Only parameters requested explicitly as their own output column (i.e. given as a bare field name) should be excluded from the wildcard, so that fields used only as function arguments are still loaded. Update the help text accordingly.