Security: DOM-based XSS via location.hash in siteInfo.js#575
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The siteInfo.js file uses `decodeURIComponent(location.hash.replace("#", "")).split(";")` to extract domain and tabId from the URL fragment, then directly interpolates `domain` into a URL without additional validation. While `punycode.toASCII()` is applied, the domain value is still user-controlled and could be manipulated. The code then sets `location.href` to an constructed URL, which could be exploited for open redirect or XSS if the domain contains malicious characters that bypass the punycode conversion.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: DOM-based XSS via location.hash in siteInfo.js
Problem
Severity:
High| File:src/ui/siteInfo.js:L21The siteInfo.js file uses
decodeURIComponent(location.hash.replace("#", "")).split(";")to extract domain and tabId from the URL fragment, then directly interpolatesdomaininto a URL without additional validation. Whilepunycode.toASCII()is applied, the domain value is still user-controlled and could be manipulated. The code then setslocation.hrefto an constructed URL, which could be exploited for open redirect or XSS if the domain contains malicious characters that bypass the punycode conversion.Solution
Validate and sanitize the domain parameter before using it in URL construction. Use URL() constructor with proper base URL to prevent injection, or implement a strict allowlist of valid domain characters. Consider using browser.runtime.sendMessage for cross-tab communication instead of URL parameters.
Changes
src/ui/siteInfo.js(modified)