Repository navigation
Conversation
both were already failing on main:
- rubocop: missing spaces inside the array brackets in backup_code.rb
- brakeman: bin/brakeman runs --ensure-latest, so 8.1.0 coming out
failed every PR. bumped to 8.1.0, which raised two new warnings:
- a weak XSS on the email typo banner. it was already escaped, but
switching to an _html translation key lets rails do the escaping
and drops the manual html_escape + html_safe
- rails 8.0 EOL on 2026-11-07. ignored with a note — the 8.1
upgrade needs its own PR before then
rails 8.0 support ends 2026-11-07. - rails 8.0.5.1 → 8.1.4 - acts_as_paranoid 0.10.3 → 0.11.0 (0.10 caps activesupport < 8.1; 0.11 only changes version support) - config.load_defaults stays at 8.0. new_framework_defaults_8_1.rb is the stock template, all commented out, so the new defaults can be flipped one at a time later - dropped the brakeman EOLRails ignore, which this makes unnecessary
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
why
rails 8.0 support ends on 2026-11-07. brakeman 8.1.0 flags it, and because of
--ensure-latestthat was failing scan_ruby on every PR.what
config.load_defaultsstays at 8.0.new_framework_defaults_8_1.rbis the stock template with everything commented out, so the new defaults can be turned on one at a time in follow-ups.action_on_path_relative_redirect = :raiseis the one worth looking at first, since this is the auth service.also in this PR
38b5d41 is the CI-fix commit from #342, cherry-picked because main's lint and scan_ruby are red. it covers the backup_code.rb lint offense, the brakeman 8.1.0 bump, and the email typo banner moving to an
_htmlkey. whichever of the two PRs merges first, the other one rebases over it. if this one goes first, #342's EOL ignore entry becomes a conflict and should simply be dropped.checked
:pendingverification factory trait, which builds a persona record with a mismatched inquiry id. that means a lot of the persona and verification specs aren't actually covering anything right now./up,/,/loginand/.well-known/openid-configurationall respond normally./oauth/discovery/keysreturns 500 in dev on both 8.0 and 8.1 because there's noOIDC_SIGNING_KEYlocally, so it's unrelated to the upgrade.worth checking after deploy