Repository navigation
Conversation
a 503 on the selfie lookup was rescued and dropped, and since the gov id photos still produced a document, the selfie was never refetched. the file download connection already retried 5xx; the api connection now does too (idempotent methods only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
the persona api client now retries 502/503/504 up to twice (0.5s, then 1s backoff), matching what the file download connection already does.
why
sentry caught a 503 from persona while fetching a selfie verification during
inquiry.approved.save_inquiry_datarescues per-verificationPersona::APIErrors, so the job carried on and built the identity document from the gov id photos alone. once a document exists,ensure_inquiry_data_savednever refetches, so a single blip permanently drops the liveness photos.faraday-retry only retries idempotent methods by default, so inquiry creation (post) is never double-sent. after retries run out the last response still reaches
request!and raisesPersona::APIErroras before.not covered
tests
two new specs in
api_service_spec.rb: a 503 followed by a 200 succeeds on the second request, and repeated 503s raise after 3 requests.