Repository navigation
feat(frontend): 分配（Split）に「なんのための分配か」の説明を付けられるようにする - #595
Open
takerunakao wants to merge 2 commits into
Open
takerunakao wants to merge 2 commits into
takerunakao wants to merge 2 commits into
Conversation
分配詳細画面には ENS 名とアドレスしか出ておらず、何のための分配か 読み取れなかった（Miro 開発会議の要望）。Split の ENS サブネームの `description` テキストレコードに説明文を保存し、作成フォームで入力・ プレビュー／詳細／一覧で表示する。コントラクト・サブグラフは変更なし。 Closes #594 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…label registration Enhanced documentation to clarify that nested labels are now verified against the live Namespace tenant on both Base and Sepolia networks. Updated the description in the SplitListCard and MasterRow components to include tone adjustments for better UI consistency. Revised SPLIT_DESCRIPTION_MAX_LENGTH comment for clarity.
YosukeMiyata
approved these changes
Sep 26, 2026
YosukeMiyata
left a comment
YosukeMiyata
left a comment
Collaborator
There was a problem hiding this comment.
イメージ通りのUIでしたー！ありがとうございましたー！
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #594
概要
開発会議（Miro）の要望「Split が現状アドレス表記 xxxxxx の部分で、なんの分配か知りたい」への対応です。
分配詳細画面には
xxxxxx.split.toban.ethとコントラクトアドレスしか出ておらず、「この分配は何のためのものか」が読み取れませんでした。Split の ENS サブネームのdescriptionテキストレコードに説明文を保存し、作成時に入力・詳細／一覧で表示するようにします。変更内容
コントラクト・サブグラフ・ENS API の変更はありません（既存の
set-nameAPI とNameData.text_recordsをそのまま利用）。app/routes/$treeId_.splits.new.tsxTextareaを追加（最大 200 文字、文字数カウンタ付き）setNameにtext_records: { description }を渡す（空欄なら送らない）app/routes/$treeId_.splits.$splitId.tsxapp/routes/$treeId_.splits._index.tsxスコープ外（フォローアップ候補）
update-nameAPI で実現可能だが、誰が編集できるかの権限設計が必要）動作確認
pnpm frontend typecheck/ Biome: pass（lefthook）descriptionテキストレコードが書き戻されることを含め、レビュー時にご確認ください🤖 Generated with Claude Code