Fix missing DedupTable definition in ddisasm runner declarations - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling the ddisasm benchmark fails with
main.cpp:1250:5: error: unknown type name 'DedupTable'. The generatedLaunchParamsstores the table by value, but its definition is only emitted in the JIT batch file.Reuse the existing
DedupTableemitter in the runner declaration beforeLaunchParams, making the type available inmain.cppand step shards. Add regression coverage for split, sharded, and unity builds. The new test fails for split and sharded builds before the fix and passes for all three after it.Fixes #89.
Validation
mainat75928cb, then successfully compiled and linked the patched ddisasm benchmark with--no-run, the issue's metadata, and a fresh build directory using Clang 20 and CUDA 12.9 (73.7 seconds). Local toolkit paths were used, ccache was disabled, and compilation used four jobs. Dataset execution was intentionally skipped by--no-run.git diff --checkpassed.