Skip to content

Fix missing DedupTable definition in ddisasm runner declarations - #90

Merged
JhinQaQ merged 1 commit into
mainfrom
codex/fix-ddisasm-dedup-table
Sep 5, 2026
Merged

JhinQaQ merged 1 commit into
mainfrom
codex/fix-ddisasm-dedup-table

Conversation

@JhinQaQ

@JhinQaQ JhinQaQ commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Compiling the ddisasm benchmark fails with main.cpp:1250:5: error: unknown type name 'DedupTable'. The generated LaunchParams stores the table by value, but its definition is only emitted in the JIT batch file.

Reuse the existing DedupTable emitter in the runner declaration before LaunchParams, making the type available in main.cpp and step shards. Add regression coverage for split, sharded, and unity builds. The new test fails for split and sharded builds before the fix and passes for all three after it.

Fixes #89.

Validation

  • Focused ddisasm, dedup-hash, and runner suites: 287 passed, 2 existing skips.
    python -m pytest tests/test_integration_ddisasm.py tests/test_dedup_hash_byte_equivalence.py tests/test_cuda_complete_runner.py tests/test_runner_byte_equivalence.py -q
  • Reproduced the exact reported error on upstream main at 75928cb, then successfully compiled and linked the patched ddisasm benchmark with --no-run, the issue's metadata, and a fresh build directory using Clang 20 and CUDA 12.9 (73.7 seconds). Local toolkit paths were used, ccache was disabled, and compilation used four jobs. Dataset execution was intentionally skipped by --no-run.
  • Ruff lint and formatting checks passed for both changed files; git diff --check passed.

@JhinQaQ
JhinQaQ requested a review from StarGazerM September 5, 2026 02:24
@JhinQaQ
JhinQaQ merged commit 06cf462 into main Sep 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: unknown type name 'DedupTable' on ddisasm

1 participant