Repository navigation
fix(wave26): Address audit findings - #373
Merged
Merged
Conversation
Why: Audit rejected Wave 26: anchor recall was store-wide and skipped freshness/trust, the associative CTE leaked cross-project/hidden ids and swallowed errors, risk inputs were inverted, and pre-flight wrote access counts and CURRENT.md. What: - src/retrieval/anchors.ts: project/trust/validity filters, orphaned and drifted anchors excluded, path normalization, stable sort. - src/associative.ts: detailed result with degradation, project/status/ trust gating through the normal read view. - src/retrieval.ts: `recordAccess`/`syncConstraints` options, associative degradation fault note, project passed to expansion. - src/hooks/preflight.ts: read-only pack, cwd, symbol/line inputs, 15-file cap, test-aware risk inputs, project-scoped anchors. - CLI: strict boolean flag, validated budget/lines, cwd and symbols. - Tests: cross-project, orphaned, degraded CTE, read purity, risk monotonicity; trajectory claims corrected; debt W26-1..5 recorded. Verification: bun test 1495 pass / 0 fail; tsc --noEmit clean; build 434 modules; secret scan clean. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all five audit blockers: project/trust/freshness gating for anchor recall, gated + degradation-aware associative expansion, corrected risk inputs, read-only pre-flight, and validated CLI flags. Adds regression tests and records W26-1..5 debt. Gate 1495/0.