Repository navigation
fix(wave27): Harden crypto and wire overlay merge to T-439 - #381
Merged
Merged
Conversation
Why: Both the code-review critic (REJECT, 4.5/10) and muse-security (8 High) rejected Wave 27: lossy tenant/branch names, unauthenticated envelope metadata, key TOCTOU, unaudited overlay merges, fail-open merge3, and overstated crypto claims. What: - Enclaves: strict names, GCM AAD (version/key_id/client/division), wx key creation with EEXIST re-read, 0700/0600 files, typed errors. - Branch overlays: base64url filenames, identity check, base_entries snapshot, three-way merge via mergeMemories3Way, lock + audit + archiveMemory, CLI set/rm and --strategy. - Attestation: domain-separated Ed25519 payload, signed version/algorithm, empty-chain rejection, safer keygen default with overwrite guard, verify-chain CLI, canonical JSON guards. - merge3: fail-closed exit, TTY-gated manual mode, stderr prompts, 0600 output, secret scan. - Enclave CLI: type enum, traversal rejection, --file/stdin content. - Tests: collision matrix, AAD relabel, chain tamper, overlay conflict, CLI contracts; claims and docs corrected; gauntlet/security ledgers. Verification: bun test 1521 pass / 0 fail; tsc clean; build 434 modules; secret scan clean. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the code-review and muse-security blockers: authenticated enclaves, strict names, key hygiene, audited three-way overlay merge, fail-closed merge3, attestation hardening. Gate 1521/0; CAPPED with residual debt recorded.