Repository navigation
feat(enclaves): Add key rotation and descope client scope - #383
Merged
Merged
Conversation
Why: W27-2 required a rotation path; W27-4 claimed a `scope: client` that was never wired. Rotating the single key previously made every vault undecryptable. What: - Versioned keyring (`.memory/enclave.keys/<key_id>.key`) + active key id; legacy `enclave.key` still readable; envelopes select by key_id. - `rotateEnclaveKey`: new active key, optional re-encryption, old keys retained for rollback, `enclave_rotate` audit. - CLI `memory enclave rotate [--no-reencrypt]`. - ADR-007 descopes `scope: client`; ticket, roadmap, research and debt corrected; enclaves stay explicit CLI vaults. - Tests: rotation with/without re-encryption, key-file perms, missing-key failure, audit. Verification: bun test 1525 pass / 0 fail; tsc clean; build 434 modules; secret scan clean. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds versioned enclave keyring + rotate with lazy re-encryption, and descopes per ADR-007. Gate 1525/0.