Skip to content

fix(claims): deliver notices without a full Registry crawl #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerocodefast merged 4 commits into from
Oct 26, 2026
Merged

fix(claims): deliver notices without a full Registry crawl #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
228652c
fix(claims): deliver notices without a full Registry crawl
zerocodefast Oct 26, 2026
002a8d3
chore(claims): preserve the notice script executable mode
zerocodefast Oct 26, 2026
0f07728
fix(claims): confirm merges for already verified owners
zerocodefast Oct 26, 2026
b0d1f6e
fix(claims): resolve upstream identities for mirrored listings
zerocodefast Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/claim-notice.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ on:
type: string
pr_title:
description: "PR title"
required: true
required: false
type: string
pr_author:
description: "PR author login"
required: true
required: false
type: string

permissions:
Expand Down Expand Up @@ -51,17 +51,31 @@ jobs:
gh label create registry-claim-pending --repo "$GITHUB_REPOSITORY" --color D4C5F9 --description "Claim notice awaits registry ingestion" --force
fi

- name: Mark notice for retry
if: github.event_name != 'schedule'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ inputs.pr_number || github.event.pull_request.number }}
run: gh pr edit "$PR_NUMBER" --repo "$GITHUB_REPOSITORY" --add-label registry-claim-pending

- name: Post claim notice
if: github.event_name != 'schedule'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ github.event.inputs.pr_number || github.event.pull_request.number }}
PR_TITLE: ${{ github.event.inputs.pr_title || github.event.pull_request.title }}
PR_AUTHOR: ${{ github.event.inputs.pr_author || github.event.pull_request.user.login }}
PENDING_RETRY: ${{ github.event_name == 'workflow_dispatch' && '1' || '0' }}
VERIFY_MERGED_PR: ${{ github.event_name == 'workflow_dispatch' }}
REGISTRY_API: https://hol.org/registry/api/v1
run: python3 scripts/post-claim-notice.py

- name: Clear delivered notice from retry queue
if: success() && github.event_name != 'schedule'
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ inputs.pr_number || github.event.pull_request.number }}
run: gh pr edit "$PR_NUMBER" --repo "$GITHUB_REPOSITORY" --remove-label registry-claim-pending

- name: Retry notices for recently merged plugins
if: github.event_name == 'schedule'
env:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/validate-contribution.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ on:
- "scripts/publish-open-pr-checks.py"
- "scripts/publish-open-pr-checks-centralized.py"
- "scripts/test_publish_open_pr_checks.py"
- "scripts/post-claim-notice.py"
- "scripts/backfill-claim-notices.py"
- "tests/test_post_claim_notice.py"
- "tests/test_backfill_claim_notices.py"
- ".github/workflows/claim-notice.yml"
- ".github/workflows/sweep-open-prs.yml"
- ".github/workflows/validate-contribution.yml"
workflow_dispatch:
Expand Down Expand Up @@ -45,6 +50,7 @@ jobs:
python3 -m unittest scripts/test_validate_contribution_branch.py
python3 -m unittest scripts/test_publish_open_pr_checks.py
python3 -m unittest scripts/test_check_alphabetical.py
python3 -m unittest tests/test_post_claim_notice.py tests/test_backfill_claim_notices.py
python3 scripts/check-alphabetical.py README.md --base-ref "$BASE_REF"
python3 scripts/validate-contribution-centralized.py \
--base-ref "$BASE_REF" \
Expand Down
Loading
Loading