Repository navigation
Conversation
Signed-off-by: Artur Reznikov <artur.reznikov@swirldslabs.com>
Signed-off-by: Artur Reznikov <artur.reznikov@swirldslabs.com>
leninmehedy
requested changes
Oct 28, 2026
Signed-off-by: Artur Reznikov <artur.reznikov@swirldslabs.com>
leninmehedy
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
--graceful-shutdown-timeoutflag (default30s), andLeaderElectionReleaseOnCancelis now enabled. The chart valuecontroller.gracefulShutdownTimeoutSecondssets the drain, and the pod'sterminationGracePeriodSecondsis set to that drain plus 15s (45s by default). The drain is best-effort; correctness relies on reconciles resuming after a restart.RegistrySelected+status.selectedSources) before patching the ConsensusCapsule. A restart between the two steps reuses the same images instead of re-selecting and rolling the pod a second time.startTimeis now only set when it is empty.pending-*by a killed operator. A pending revision older thanspec.timeoutis marked failed, then upgraded; a younger one is waited out. The release is now read once per reconcile. The Helm client gainsUnlockandReleaseInfo.LastDeployed.Failed, and failure or spec-mutation rejection clears a staleReady.LastTransitionTimeon every reconcile.internal/crashtestwraps a client so it "dies" after a chosen write.internal/controller/restart_safety_test.gocover Execute, Genesis, Prepare prefetch, ConsensusCapsule image pins and Orbit.test/integration/restart/kills a real manager on envtest mid-upgrade and mid-Helm-install, and asserts that a second manager finishes the operation.Per-controller restart notes
status.resolvedImagesand applied after status writes.pending-*release, then upgrades.Succeededis terminal.Related Issues