saml: close the IdP metadata HTTP response body - #195
Open
pacocartones wants to merge 1 commit into
Open
pacocartones wants to merge 1 commit into
pacocartones wants to merge 1 commit into
Conversation
fetchIDPMetadata reads res.Body but never closes it, leaking the connection. The two other HTTP fetch sites in this repo already close it correctly (oidc/provider.go and jwt/keyset.go both defer resp.Body.Close()). Signed-off-by: pacocartones <pacocartones@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchIDPMetadata(saml/sp.go) readsres.Bodyviaio.ReadAllbut never closes it, so the response body / connection leaks. The two other HTTP fetch sites in this repo already handle this correctly —oidc/provider.goandjwt/keyset.gobothdefer resp.Body.Close(). This adds the samedefer res.Body.Close()right after the successfulhttp.Get.One-line change;
go build ./saml/passes.