fix: merge address info when aliasing entries to handle out-of-order DNS records - #151
fix: merge address info when aliasing entries to handle out-of-order DNS records#151Yanhu007 wants to merge 1 commit into
Conversation
When A/AAAA records arrive before SRV records, the alias function overwrites the existing entry (which has the IP address) with the SRV's entry (which has the port), losing the address information. This causes the service entry to never become complete, and the service is not discovered. Now when the alias destination already has an entry with address information, merge it into the source entry before overwriting. This handles out-of-order DNS record delivery, as seen with devices like the Alfen EV Charger. Fixes hashicorp#145
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
I ran into the same problem and have a similar patch locally :/ @Yanhu007 how do you feel about the CLA? Do you think getting that green might get more traction on this PR? |
Fixes #145
Problem
When DNS records arrive in certain orders (A/AAAA before SRV), the
aliasfunction overwrites an existing entry that already has an IP address with the SRV entry that only has port/host info. The IP address is lost, and the entry never becomes complete.Example failure sequence:
device.local.→ creates entry with IPdevice._service._tcp.local.with targetdevice.local.→alias()overwrites the A-record entry, losing the IPThis was reported with Alfen EV Chargers but affects any device that sends A/AAAA records before SRV records.
Fix
In
alias(), when the destination key already has an entry with address information, merge the addresses into the source entry before overwriting the map entry.Testing
All existing tests pass.