Repository navigation
Backport changes for v1.2.8 release - #371
Merged
Merged
Conversation
* Update GCP packer plugin
Get instance name via metadata server instead of using ${HOSTNAME}
Depending on the OS, ${HOSTNAME} can resolve to the FQDN (ie: `{NAME}.{ZONE}.c.{PROJECT}.internal`) which causes the startup script to fail during completion, even if all other tasks were successful.
* Remove unnecessary call to basename
grpc dependency upgrade
* build(deps): bump github.com/hashicorp/packer-plugin-sdk Bumps [github.com/hashicorp/packer-plugin-sdk](https://github.com/hashicorp/packer-plugin-sdk) from 0.6.10 to 0.6.11. - [Release notes](https://github.com/hashicorp/packer-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/packer-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/packer-plugin-sdk@v0.6.10...v0.6.11) --- updated-dependencies: - dependency-name: github.com/hashicorp/packer-plugin-sdk dependency-version: 0.6.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * run make generate * Module update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: make boot disk size to match source image when disk_size is unset Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw> * docs: update for the disk_size description Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw> --------- Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw>
The retry loop added to ImportOSLoginSSHKey in #324 declares err with := on each iteration, shadowing the err declared before the loop. When the loop ends on anything but success (a non-409 error, or the last of 10 conflicts) it returns that outer err, which is always nil, so the caller gets (nil, nil). #334 guarded the resulting nil dereference, which turned the panic into "Error importing SSH public key for OSLogin: no PosixAccounts available" and hides the real API error, e.g.: googleapi: Error 400: Login profile size exceeds 32 KiB. Delete profile values to make additional space. Assign to the outer err instead, and make the wait between retries replaceable so the retry path can be unit tested. The new tests run the real OS Login client against an httptest server; the non-409 and persistent-409 cases fail on the previous code.
Bumps [github.com/hashicorp/packer-plugin-sdk](https://github.com/hashicorp/packer-plugin-sdk) from 0.6.11 to 0.6.12. - [Release notes](https://github.com/hashicorp/packer-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/packer-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/packer-plugin-sdk@v0.6.11...v0.6.12) --- updated-dependencies: - dependency-name: github.com/hashicorp/packer-plugin-sdk dependency-version: 0.6.12 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Update the Go version and refresh module dependencies.
tanmay-hc
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport the changes merged to
mainsince the v1.2.7 release to therelease/1.2.xbranch for the v1.2.8 release. This includes bug fixes for startup scripts, image deprecation handling, and OS Login key imports; fitting boot disk size to the source image by default; and dependency, Go version, and copyright header updates. Prepare the branch version as1.2.8-dev.