Skip to content

SRE-927: Ignore the concurrency.queue syntax gap - #102

Merged
TimDiekmann merged 2 commits into
mainfrom
t/sre-927-actionlint-severity
Aug 11, 2026
Merged

SRE-927: Ignore the concurrency.queue syntax gap#102
TimDiekmann merged 2 commits into
mainfrom
t/sre-927-actionlint-severity

Conversation

@TimDiekmann

@TimDiekmann TimDiekmann commented Aug 11, 2026

Copy link
Copy Markdown
Member

Purpose

actionlint 1.7.12 does not know the concurrency.queue key (rhysd/actionlint#654), which hashintel/hash uses in its deploy workflow. Same category as the $/ ignores from #100: a real GitHub feature the linter lags behind on.

Related links

What does this change?

  • Third -ignore on the actionlint step for the concurrency.queue syntax-check message, tracked for removal in SRE-941 alongside the $/ ignores

The intermediate commit gating shellcheck at error level is reverted — findings in the consumer repos get fixed instead (SRE-927 fleet PRs).

@TimDiekmann TimDiekmann self-assigned this Aug 11, 2026
@TimDiekmann TimDiekmann changed the title SRE-927: Gate shellcheck at error level and ignore concurrency.queue SRE-927: Ignore the concurrency.queue syntax gap Aug 11, 2026
@TimDiekmann
TimDiekmann marked this pull request as ready for review August 11, 2026 10:05
Copilot AI lite review requested due to automatic review settings August 11, 2026 10:05
@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI lint configuration only; no runtime or security impact.

Overview
Preflight actionlint now ignores the unexpected key "queue" for "concurrency" section diagnostic so workflows using GitHub’s valid concurrency.queue setting (e.g. in consumer repos) don’t fail CI while actionlint lags behind (rhysd/actionlint#654).

The existing SRE-941 TODO is extended to drop this ignore alongside the $/ rules once upstream supports both syntaxes.

Reviewed by Cursor Bugbot for commit d7a1c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable actionlint preflight workflow to suppress a known false-positive triggered by GitHub Actions’ concurrency.queue syntax, which actionlint v1.7.12 does not yet recognize (tracked for later removal alongside existing $/ ignores).

Changes:

  • Add a third -ignore pattern to filter the concurrency.queue “unexpected key" lint message.
  • Expand the TODO comment to track both upstream actionlint gaps ($/ and concurrency.queue) under SRE-941.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@TimDiekmann
TimDiekmann added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit 69449a7 Aug 11, 2026
12 checks passed
@TimDiekmann
TimDiekmann deleted the t/sre-927-actionlint-severity branch August 11, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants