Skip to content

FE-1316: Audit current system authority and drift - #412

Open
lunelson wants to merge 3 commits into
ln/fe-1311-integrity-cleanupfrom
ln/fe-1316-system-authority-audit
Open

FE-1316: Audit current system authority and drift#412
lunelson wants to merge 3 commits into
ln/fe-1311-integrity-cleanupfrom
ln/fe-1316-system-authority-audit

Conversation

@lunelson

@lunelson lunelson commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Why

After a run of related work landed, this was a scheduled check-in: are we tracking every open thread correctly, and has anything drifted out of sync between what the docs say and what the code actually does? This is a review pass, not new product functionality.

What

  • Reviewed 13 areas touched by recent work for leftover dead behavior, doc/code drift, and follow-up work that had lost its owner.
  • Found and fixed one real, if small, product issue: outdated on-screen guidance text shown during a review step that no longer matched how corrections actually work.
  • Confirmed the surrounding executor, comparison, and tracing subsystems are each on track with their existing owners rather than silently stalled.
  • Opened two focused, scoped follow-ups instead of leaving loose ends: reconciling drifted internal documentation, and closing a gap in how we fingerprint automated test evidence (see the two PRs stacked above this one).

How to test

This is an audit/planning pass with one small text fix.

  1. npm run check passes.
  2. The two admitted follow-on issues (FE-1317, FE-1318) exist in Linear and are addressed by the PRs stacked on top of this one.

lunelson commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@lunelson lunelson changed the title FE-1316: Charter current-system reorientation audit FE-1316: Audit current system authority and drift Aug 7, 2026
@lunelson
lunelson marked this pull request as ready for review August 7, 2026 16:16
Copilot AI lite review requested due to automatic review settings August 7, 2026 16:16
@cursor

cursor Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Planning-archive and prompt-text updates only; present_digest execute behavior is unchanged aside from model-facing guidance strings.

Overview
FE-1316 system reorientation audit is recorded as complete: thirteen concerns get evidence-backed dispositions, the temporary audit ledger is gone, and two new “next” frontiers are admitted with full definitions—canonical-document-reconciliation (normative doc drift) and host-landing-oracle-identity (PTY oracle-pack hashing).

The only runtime change fixes stale present_digest prompt guidance that still described approve / request changes / reject continuations. Tool description and promptGuidelines now describe conversational free-text correction on a continued ask, clarify that continuation does not capture the digest, and point models to a successor digest plus a separate acceptsDigest ask for capture authorization. Exchange extension tests assert the new wording and explicitly reject the old tri-state review vocabulary.

Reviewed by Cursor Bugbot for commit d3b8451. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a documentation/audit pass following FE-1316, tightening the structured-exchange “present_digest → ask” guidance to match the current conversational correction flow, and updating planning artifacts to record the audit closeout plus two newly admitted follow-on frontiers.

Changes:

  • Updated present_digest tool description/guidelines to reflect free-text correction continuations and the separate acceptsDigest capture step.
  • Adjusted extension tests to assert the new guidance and reject the deprecated approve/request-changes/reject phrasing.
  • Recorded FE-1316 closeout and admitted frontiers in memory/PLAN.md, with corresponding archival notes in docs/archive/PLAN_HISTORY.md.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/.pi/extensions/exchanges/present-digest.ts Updates the tool’s user-facing guidance to match the current correction + capture flow.
src/.pi/extensions/tests/exchanges-extension.test.ts Updates assertions to reflect the revised guidance strings and remove expectations for deprecated phrasing.
memory/PLAN.md Logs FE-1316 completion and adds definitions + sequencing entries for two new follow-on frontiers.
docs/archive/PLAN_HISTORY.md Archives FE-1316 closeout narrative and records the admitted follow-on frontiers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings August 10, 2026 09:12
@lunelson
lunelson force-pushed the ln/fe-1316-system-authority-audit branch from 51f3e07 to d3b8451 Compare August 10, 2026 09:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants