SRE-927: Call the centralized actionlint preflight workflow - #426
Conversation
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit b1c378f. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
Wires this repo’s preflight workflows to use the centralized hashintel/.github reusable workflows, adding an actionlint-based workflow lint step that runs on PRs.
Changes:
- Consolidates
pull_requestpreflights into.github/workflows/preflight.yml(todo-comments + new centralized actionlint lint job). - Moves
pull_request_targetpreflights into.github/workflows/preflight-target.ymlto preserve the existing “Dependencies” and “PR title” checks. - Removes the now-redundant
.github/workflows/preflight-todo-comments.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/preflight.yml | Consolidates PR preflight checks and adds centralized actionlint linting. |
| .github/workflows/preflight-todo-comments.yml | Deletes the standalone todo-comments preflight workflow after consolidation. |
| .github/workflows/preflight-target.yml | Introduces the pull_request_target preflight workflow for dependencies and PR-title checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/preflight.yml:22
editedis included in the workflow trigger to support the todo-comments scan, but that also causes the actionlint job to rerun when only the PR title/description is edited. This adds unnecessary CI work/noise; the lint job can be skipped for thepull_requesteditedaction while still running on other PR actions andmerge_group.
lint:
name: Lint
permissions:
contents: read
uses: hashintel/.github/.github/workflows/preflight-actionlint.yml@69449a772a55c55a101d4fefdceb4024b6bc3107 # main
Purpose
Wires up the centralized actionlint preflight (hashintel/.github#100–#102), which lints all workflow files on every PR.
Related links
What does this change?
pull_requestpreflights are consolidated into onepreflight.yml: Todo comments plus the new Lint job calling the centralizedpreflight-actionlint.yml(check name:Preflight / Lint / Actions). Thepull_request_targetfile moves topreflight-target.yml; check names stay unchanged.How to test this?
Preflight / Lint / Actionscheck runs on this PR