Skip to content

SRE-927: Call the centralized actionlint preflight workflow - #426

Merged
TimDiekmann merged 3 commits into
mainfrom
t/sre-927-migrate-same-repository-action-and-workflow-references-to
Aug 11, 2026
Merged

SRE-927: Call the centralized actionlint preflight workflow#426
TimDiekmann merged 3 commits into
mainfrom
t/sre-927-migrate-same-repository-action-and-workflow-references-to

Conversation

@TimDiekmann

@TimDiekmann TimDiekmann commented Aug 11, 2026

Copy link
Copy Markdown
Member

Purpose

Wires up the centralized actionlint preflight (hashintel/.github#100#102), which lints all workflow files on every PR.

Related links

What does this change?

  • The pull_request preflights are consolidated into one preflight.yml: Todo comments plus the new Lint job calling the centralized preflight-actionlint.yml (check name: Preflight / Lint / Actions). The pull_request_target file moves to preflight-target.yml; check names stay unchanged.

How to test this?

  • The Preflight / Lint / Actions check runs on this PR

@TimDiekmann TimDiekmann self-assigned this Aug 11, 2026
@TimDiekmann
TimDiekmann marked this pull request as ready for review August 11, 2026 10:55
Copilot AI lite review requested due to automatic review settings August 11, 2026 10:55
@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to GitHub Actions wiring and reusable workflow pins; no application runtime or security logic is affected.

Overview
Preflight CI is split and extended so standard PR checks and pull_request_target checks live in separate workflows, and every PR gets centralized Actionlint on workflow files.

preflight.yml now runs only on pull_request / merge_group and inlines Todo comments plus a new Lint job that calls hashintel/.github’s preflight-actionlint.yml (check: Preflight / Lint / Actions). Dependencies and PR title move to new preflight-target.yml, which keeps pull_request_target (and a path filter for self-updates) so those check names stay the same. The standalone preflight-todo-comments.yml is removed, and reusable workflow refs are pinned to 69449a77… on main.

Reviewed by Cursor Bugbot for commit b1c378f. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Wires this repo’s preflight workflows to use the centralized hashintel/.github reusable workflows, adding an actionlint-based workflow lint step that runs on PRs.

Changes:

  • Consolidates pull_request preflights into .github/workflows/preflight.yml (todo-comments + new centralized actionlint lint job).
  • Moves pull_request_target preflights into .github/workflows/preflight-target.yml to preserve the existing “Dependencies” and “PR title” checks.
  • Removes the now-redundant .github/workflows/preflight-todo-comments.yml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/preflight.yml Consolidates PR preflight checks and adds centralized actionlint linting.
.github/workflows/preflight-todo-comments.yml Deletes the standalone todo-comments preflight workflow after consolidation.
.github/workflows/preflight-target.yml Introduces the pull_request_target preflight workflow for dependencies and PR-title checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/preflight-target.yml
Copilot AI review requested due to automatic review settings August 11, 2026 11:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/workflows/preflight.yml:22

  • edited is included in the workflow trigger to support the todo-comments scan, but that also causes the actionlint job to rerun when only the PR title/description is edited. This adds unnecessary CI work/noise; the lint job can be skipped for the pull_request edited action while still running on other PR actions and merge_group.
  lint:
    name: Lint
    permissions:
      contents: read
    uses: hashintel/.github/.github/workflows/preflight-actionlint.yml@69449a772a55c55a101d4fefdceb4024b6bc3107 # main

@TimDiekmann
TimDiekmann added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit ea6e479 Aug 11, 2026
10 checks passed
@TimDiekmann
TimDiekmann deleted the t/sre-927-migrate-same-repository-action-and-workflow-references-to branch August 11, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants