SRE-891, SRE-904: Pass the Renovate cipher key and fix the todo-comments trigger - #155
Conversation
PR SummaryLow Risk Overview Housekeeping bumps the reusable workflow pin to Todo comments moves out of Other hashintel/.github reusable workflow pins in preflight/housekeeping are updated to the same SHA. Reviewed by Cursor Bugbot for commit b29ef9c. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
Updates this repo’s GitHub Actions workflows to align with the split Renovate reusable workflow contract (mint/run job boundary) and restores the todo-comments scan so it runs under pull_request (instead of being silently skipped under pull_request_target).
Changes:
- Bump
hashintel/.githubreusable workflow pins tob7a5d7f…. - Add a dedicated
preflight-todo-comments.ymlworkflow triggered onpull_requestand remove the todo-comments job frompreflight.yml. - Pass
RENOVATE_TOKEN_ENC_KEYinto the Renovate housekeeping reusable workflow viasecrets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/preflight.yml | Updates reusable workflow pins and removes the inline todo-comments job from the main preflight workflow. |
| .github/workflows/preflight-todo-comments.yml | Introduces a dedicated workflow to run the todo-comments scan on pull_request events. |
| .github/workflows/housekeeping.yml | Updates the housekeeping reusable workflow pin and forwards RENOVATE_TOKEN_ENC_KEY to match the new Renovate job contract. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Purpose
hashintel/.github#99 split the centralized Renovate workflow into a mint job and a run job; the installation token crosses the job boundary encrypted with
RENOVATE_TOKEN_ENC_KEY. This wires the caller up to that contract, mirroring hashintel/hash#9192, and re-enables the todo-comments scan on PRs.Related links
What does this change?
housekeeping.yml: bump thehashintel/.githubpin tob7a5d7fand passRENOVATE_TOKEN_ENC_KEYthrough to the reusable workflow (the secret is already set on this repo)preflight.yml: move the todo-comments job into a dedicatedpreflight-todo-comments.ymltriggered onpull_request(matching hash and brunch). The reusable scan job ispull_request-only since SRE-891, so it was silently skipped when called underpull_request_target. The check name staysTodo comments / Scan.hashintel/.githubpins bumped to the same SHAHow to test this?
Todo comments / Scancheck on this PR should now report success/failure instead of skipped