No headers bodytype - #1918
Merged
Merged
No headers bodytype#1918
Conversation
Recurse through `Headers hdrs` just like any other decorator that should be ignored.
Contributor
|
Thanks for doing this. |
Contributor
|
The compilation failure seems related to this change, but I haven't looked very much into it. Would you say it is a problem with this PR, or a problem with the CI suite? |
lrworth
force-pushed
the
no-headers-bodytype
branch
from
September 8, 2026 22:15
5a37772 to
2640ded
Compare
Contributor
Author
As rare as it is these days, PEBKAC. |
Unconditionally requesting `ToSchema a` etc means that we erroneously demand `ToSchema NoContent`. Instead delegate to the `HasOpenApi` instance for the related `Verb`, allowing the overlapping instances for `NoContent` to be selected.
lrworth
force-pushed
the
no-headers-bodytype
branch
from
September 8, 2026 22:59
2640ded to
7756702
Compare
LaurentRDC
approved these changes
Sep 17, 2026
LaurentRDC
left a comment
LaurentRDC
left a comment
Contributor
There was a problem hiding this comment.
This is great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a renewal of this PR against biocad/servant-openapi3.
Stop
BodyTypesincorrectly addingNoContentto the list of body types if it appears within aHeaders(on endpoints that set response headers but don't return a response body).