feat: CI gate: run the existing test suite and typecheck on every PR in - #8
Open
andrei-hasna wants to merge 1 commit into
Open
feat: CI gate: run the existing test suite and typecheck on every PR in#8andrei-hasna wants to merge 1 commit into
andrei-hasna wants to merge 1 commit into
Conversation
CI gate: run the existing test suite and typecheck on every PR in models — the repo has tests but no CI workflow at all [loop-infinity-300pr] REPO: https://github.com/hasna/models WHAT TO CHANGE This repo has a real test suite (6 test files at HEAD) and a `test` script, but there is no .github/workflows directory at all, so nothing runs on a pull request. Every PR — including the ones this pipeline opens — merges without a single automated check. Add a single workflow at .github/workflows/ci.yml that runs on pull_request and on push to the default branch. DONE LOOKS LIKE - .github/workflows/ci.yml exists and runs, in one job: checkout, `oven-sh/setup-bun`, `bun install --frozen-lockfile`, `bun run typecheck`, `bun run build`, `bun test`. - Pin the actions to a major version tag (for example actions/checkout@v4, oven-sh/setup-bun@v2) rather than @master. - The workflow must actually be green on this PR. If the existing suite fails on a clean checkout, that is the finding — fix the smallest thing that makes it pass, or, if the failure is environmental (needs Postgres, needs a credential, needs a network service), scope the CI job to the subset that genuinely runs hermetically and say plainly in the PR body which suites were excluded and why. Do NOT make it green with continue-on-error, `|| true`, or by skipping tests. - No production source changed beyond what is needed to make the gate honest. VERIFY - The workflow run on this PR is green in GitHub Actions. - `bun install --frozen-lockfile && bun test` reproduces the same result locally. EVIDENCE Checked 2026-07-29 against GitHub HEAD via the GitHub API: `repos/hasna/models/actions/workflows` returned total_count 0, and the recursive git tree at HEAD contains 6 test files. package.json declares test=True, build=True, typecheck=True. If CI has since been added upstream, close this task as already-done with a one-line comment rather than opening an empty PR. PROCESS: work in a branch off the default branch, one focused change, conventional commit, open a PR. Do not bundle unrelated cleanups. If the repo has a CHANGELOG, add an entry. X-Factory-Run: run_ffc7a233a54a X-Factory-Task: 8f47fe08-735d-456f-980d-773e4dc450c6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
CI gate: run the existing test suite and typecheck on every PR in models — the repo has tests but no CI workflow at all [loop-infinity-300pr]
REPO: https://github.com/hasna/models
WHAT TO CHANGE
This repo has a real test suite (6 test files at HEAD) and a
testscript, but there is no .github/workflows directory at all, so nothing runs on a pull request. Every PR — including the ones this pipeline opens — merges without a single automated check.Add a single workflow at .github/workflows/ci.yml that runs on pull_request and on push to the default branch.
DONE LOOKS LIKE
oven-sh/setup-bun,bun install --frozen-lockfile,bun run typecheck,bun run build,bun test.|| true, or by skipping tests.VERIFY
bun install --frozen-lockfile && bun testreproduces the same result locally.EVIDENCE
Checked 2026-07-29 against GitHub HEAD via the GitHub API:
repos/hasna/models/actions/workflowsreturned total_count 0, and the recursive git tree at HEAD contains 6 test files. package.json declares test=True, build=True, typecheck=True. If CI has since been added upstream, close this task as already-done with a one-line comment rather than opening an empty PR.PROCESS: work in a branch off the default branch, one focused change, conventional commit, open a PR. Do not bundle unrelated cleanups. If the repo has a CHANGELOG, add an entry.
Verification
Run
run_ffc7a233a54a· backendcodewith· task8f47fe08-735d-456f-980d-773e4dc450c6🏭 Generated by @hasnaxyz/factory
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.