ci: hasna/models has no GitHub Actions workflow — add a test+typecheck - #9
Open
andrei-hasna wants to merge 1 commit into
Open
ci: hasna/models has no GitHub Actions workflow — add a test+typecheck#9andrei-hasna wants to merge 1 commit into
andrei-hasna wants to merge 1 commit into
Conversation
CI: hasna/models has no GitHub Actions workflow — add a test+typecheck gate on pull_request This repo has no GitHub Actions workflow at all — there is no automated gate on pull requests, so nothing catches a broken build or a failing test before merge. Add a minimal, correct CI workflow at .github/workflows/ci.yml for open-models (github.com/hasna/models). Trigger on push and pull_request to the default branch. Use actions/checkout and oven-sh/setup-bun; run `bun install --frozen-lockfile` (fall back to `bun install` if there is no lockfile), then ONLY the scripts that actually exist in package.json among typecheck / build / test — skip any that are absent, do not invent scripts. Keep it minimal and GREEN: if a script exists but is already failing on the default branch, do not paper over it — either scope the workflow to the scripts that pass and say so in the PR body, or fix the failure if it is trivial and clearly in scope. Verify: confirm the workflow file parses (valid YAML, correct action refs) and that each command you reference is a real script in package.json. Scope: the workflow file only, optionally a CI badge line in README. Do NOT modify product code. Open a PR against the default branch; do not merge. X-Factory-Run: run_342f7a321266 X-Factory-Task: 41e57872-8ab7-4f2a-a225-a7dc29a2566a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
CI: hasna/models has no GitHub Actions workflow — add a test+typecheck gate on pull_request
This repo has no GitHub Actions workflow at all — there is no automated gate on pull requests, so nothing catches a broken build or a failing test before merge.
Add a minimal, correct CI workflow at .github/workflows/ci.yml for open-models (github.com/hasna/models). Trigger on push and pull_request to the default branch. Use actions/checkout and oven-sh/setup-bun; run
bun install --frozen-lockfile(fall back tobun installif there is no lockfile), then ONLY the scripts that actually exist in package.json among typecheck / build / test — skip any that are absent, do not invent scripts.Keep it minimal and GREEN: if a script exists but is already failing on the default branch, do not paper over it — either scope the workflow to the scripts that pass and say so in the PR body, or fix the failure if it is trivial and clearly in scope.
Verify: confirm the workflow file parses (valid YAML, correct action refs) and that each command you reference is a real script in package.json.
Scope: the workflow file only, optionally a CI badge line in README. Do NOT modify product code. Open a PR against the default branch; do not merge.
Verification
Run
run_342f7a321266· backendcodewith· task41e57872-8ab7-4f2a-a225-a7dc29a2566a🏭 Generated by @hasnaxyz/factory
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.