Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Assets/Tests/Editor/CliSetupApplicationServiceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ public async Task InstallGlobalCliAsync_UsesMinimumRequiredCliReleaseTag()
[Test]
public void GetMinimumRequiredCliVersion_RequiresCompileRecoveryCliRelease()
{
// Verifies this package release requires the CLI that polls accepted compile result files.
// Verifies this package release requires the CLI that polls stored compile status.
CliSetupApplicationService service = new(
new FakeCliInstallationDetector(new string[] { null }),
new FakeNativeCliInstaller());

Assert.That(service.GetMinimumRequiredCliVersion(), Is.EqualTo("3.0.0-beta.20"));
Assert.That(service.GetMinimumRequiredCliVersion(), Is.EqualTo("3.0.0-beta.22"));
}

[Test]
Expand All @@ -49,7 +49,7 @@ public void GetMinimumRequiredCliReleaseTag_UsesCliGitHubReleaseTag()
new FakeCliInstallationDetector(new string[] { null }),
new FakeNativeCliInstaller());

Assert.That(service.GetMinimumRequiredCliReleaseTag(), Is.EqualTo("cli-v3.0.0-beta.20"));
Assert.That(service.GetMinimumRequiredCliReleaseTag(), Is.EqualTo("cli-v3.0.0-beta.22"));
}

[Test]
Expand Down
153 changes: 0 additions & 153 deletions Assets/Tests/Editor/CompileResultPersistenceServiceTests.cs

This file was deleted.

110 changes: 110 additions & 0 deletions Assets/Tests/Editor/CompileSessionResultServiceTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
using System;
using NUnit.Framework;
using UnityEditor.Compilation;

using io.github.hatayama.UnityCliLoop.FirstPartyTools;

namespace io.github.hatayama.UnityCliLoop.Tests.Editor
{
/// <summary>
/// Tests compile result conversion before results are stored for CLI polling.
/// </summary>
[TestFixture]
public sealed class CompileSessionResultServiceTests
{
[Test]
public void CreateCompileResult_WhenNormalCompileCompletes_MapsDetailedIssues()
{
// Verifies normal compile results keep detailed error and warning entries.
CompilerMessage error = new CompilerMessage
{
type = CompilerMessageType.Error,
message = "error",
file = "Assets/Test.cs",
line = 12
};
CompilerMessage warning = new CompilerMessage
{
type = CompilerMessageType.Warning,
message = "warning",
file = "Assets/Test.cs",
line = 15
};
CompileResult result = new CompileResult(
success: false,
errorCount: 1,
warningCount: 1,
completedAt: DateTime.Now,
messages: new[] { error, warning },
errors: new[] { error },
warnings: new[] { warning });

UnityCliLoopCompileResult response =
CompileSessionResultService.CreateCompileResult(result, forceRecompile: false);

Assert.That(response.Success, Is.False);
Assert.That(response.ErrorCount, Is.EqualTo(1));
Assert.That(response.WarningCount, Is.EqualTo(1));
Assert.That(response.Errors, Has.Length.EqualTo(1));
Assert.That(response.Warnings, Has.Length.EqualTo(1));
Assert.That(response.Errors[0].Message, Is.EqualTo("error"));
}

[Test]
public void CreateCompileResult_WhenForceCompileIsUnknown_DropsDetailedIssues()
{
// Verifies force compile results do not pretend Unity returned detailed issue content.
CompilerMessage error = new CompilerMessage
{
type = CompilerMessageType.Error,
message = "error",
file = "Assets/Test.cs",
line = 12
};
CompileResult result = new CompileResult(
success: null,
errorCount: 1,
warningCount: 0,
completedAt: DateTime.Now,
messages: new[] { error },
errors: new[] { error },
warnings: Array.Empty<CompilerMessage>(),
isIndeterminate: true,
message: null);

UnityCliLoopCompileResult response =
CompileSessionResultService.CreateCompileResult(result, forceRecompile: true);

Assert.That(response.Success, Is.Null);
Assert.That(response.ErrorCount, Is.Null);
Assert.That(response.WarningCount, Is.Null);
Assert.That(response.Errors, Is.Null);
Assert.That(response.Warnings, Is.Null);
Assert.That(response.Message, Is.Null);
}

[Test]
public void CreateCompileResult_WhenForceCompileHasOutcome_DropsCountsAndDetailedIssues()
{
// Verifies force compile does not report counts or issue lists even when a high-level outcome exists.
CompileResult result = new CompileResult(
success: true,
errorCount: 0,
warningCount: 2,
completedAt: DateTime.Now,
messages: Array.Empty<CompilerMessage>(),
errors: Array.Empty<CompilerMessage>(),
warnings: Array.Empty<CompilerMessage>());

UnityCliLoopCompileResult response =
CompileSessionResultService.CreateCompileResult(result, forceRecompile: true);

Assert.That(response.Success, Is.True);
Assert.That(response.ErrorCount, Is.Null);
Assert.That(response.WarningCount, Is.Null);
Assert.That(response.Errors, Is.Null);
Assert.That(response.Warnings, Is.Null);
Assert.That(response.Message, Is.Null);
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading