Skip to content

chore: Keep setup skills step rendering separate from the window #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatayama merged 1 commit into from
Jul 6, 2026
Merged

chore: Keep setup skills step rendering separate from the window #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions Assets/Tests/Editor/SetupWizardWindowTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ public void FilterInstallableSkillTargets_ExcludesTargetsWithoutSkillsDirectory(
};

List<SkillSetupTargetInfo> installableTargets =
SetupWizardWindow.FilterInstallableSkillTargets(targets);
SetupWizardSkillsStepPresenter.FilterInstallableSkillTargets(targets);

Assert.That(installableTargets.Count, Is.EqualTo(2));
Assert.That(installableTargets[0].DirName, Is.EqualTo(".claude"));
Expand Down Expand Up @@ -498,7 +498,7 @@ public void CanManageSkills_WhenCliIsInstalled_ReturnsTrue()
public void ShouldShowSkillsTargetRow_WhenFirstInstallAndCliMissing_ReturnsTrue()
{
// Verifies that first-time setup can choose a skill target before CLI installation.
bool shouldShow = SetupWizardWindow.ShouldShowSkillsTargetRowForSetupWizard(
bool shouldShow = SetupWizardSkillsStepPresenter.ShouldShowSkillsTargetRowForSetupWizard(
shouldUseFirstInstallSkillsUi: true);

Assert.That(shouldShow, Is.True);
Expand All @@ -508,7 +508,7 @@ public void ShouldShowSkillsTargetRow_WhenFirstInstallAndCliMissing_ReturnsTrue(
public void ShouldShowSkillsTargetRow_WhenNotFirstInstall_ReturnsFalse()
{
// Verifies that returning setup keeps the compact target row hidden.
bool shouldShow = SetupWizardWindow.ShouldShowSkillsTargetRowForSetupWizard(
bool shouldShow = SetupWizardSkillsStepPresenter.ShouldShowSkillsTargetRowForSetupWizard(
shouldUseFirstInstallSkillsUi: false);

Assert.That(shouldShow, Is.False);
Expand All @@ -518,7 +518,7 @@ public void ShouldShowSkillsTargetRow_WhenNotFirstInstall_ReturnsFalse()
public void ShouldShowSkillsTargetList_WhenCliMissing_ReturnsFalse()
{
// Verifies that multi-target status rows stay hidden until the CLI can inspect skill state.
bool shouldShow = SetupWizardWindow.ShouldShowSkillsTargetListForSetupWizard(
bool shouldShow = SetupWizardSkillsStepPresenter.ShouldShowSkillsTargetListForSetupWizard(
canManageSkills: false,
shouldUseFirstInstallSkillsUi: false);

Expand All @@ -529,7 +529,7 @@ public void ShouldShowSkillsTargetList_WhenCliMissing_ReturnsFalse()
public void ShouldShowSkillsTargetList_WhenCliInstalledAndNotFirstInstall_ReturnsTrue()
{
// Verifies that returning users keep the multi-target skill status view.
bool shouldShow = SetupWizardWindow.ShouldShowSkillsTargetListForSetupWizard(
bool shouldShow = SetupWizardSkillsStepPresenter.ShouldShowSkillsTargetListForSetupWizard(
canManageSkills: true,
shouldUseFirstInstallSkillsUi: false);

Expand Down Expand Up @@ -649,7 +649,7 @@ public void ShouldCheckCliPathSetupForSetupWizard_RequiresPackageOwnedCli(
public void CreateFirstInstallSkillTarget_WhenClaudeSelected_ReturnsClaudeProjectTarget()
{
SkillSetupTargetInfo target =
SetupWizardWindow.CreateFirstInstallSkillTarget(SkillsTarget.Claude, true);
SetupWizardSkillsStepPresenter.CreateFirstInstallSkillTarget(SkillsTarget.Claude, true);

Assert.That(target.DisplayName, Is.EqualTo("Claude Code"));
Assert.That(target.DirName, Is.EqualTo(".claude"));
Expand All @@ -669,7 +669,7 @@ public void CreateFirstInstallSkillTarget_ReturnsMappedTarget(
string expectedInstallFlag)
{
SkillSetupTargetInfo target =
SetupWizardWindow.CreateFirstInstallSkillTarget(targetType, true);
SetupWizardSkillsStepPresenter.CreateFirstInstallSkillTarget(targetType, true);

Assert.That(target.DisplayName, Is.EqualTo(expectedDisplayName));
Assert.That(target.DirName, Is.EqualTo(expectedDirName));
Expand All @@ -682,7 +682,7 @@ public void CreateFirstInstallSkillTarget_ReturnsMappedTarget(
public void CreateFirstInstallSkillTarget_WhenGroupingDisabled_KeepsTargetMetadata()
{
SkillSetupTargetInfo target =
SetupWizardWindow.CreateFirstInstallSkillTarget(SkillsTarget.Claude, false);
SetupWizardSkillsStepPresenter.CreateFirstInstallSkillTarget(SkillsTarget.Claude, false);

Assert.That(target.DisplayName, Is.EqualTo("Claude Code"));
Assert.That(target.DirName, Is.EqualTo(".claude"));
Expand All @@ -703,7 +703,7 @@ public void GetSelectedSkillTargetInfo_WhenDetectedTargetExists_ReturnsDetectedS
installState: SkillInstallState.Installed)
};

SkillSetupTargetInfo target = SetupWizardWindow.GetSelectedSkillTargetInfo(
SkillSetupTargetInfo target = SetupWizardSkillsStepPresenter.GetSelectedSkillTargetInfo(
targets,
SkillsTarget.Claude,
groupSkillsUnderUnityCliLoop: true);
Expand All @@ -727,7 +727,7 @@ public void GetFirstInstallableSkillTargets_WhenSelectedTargetIsInstalled_Return
};

List<SkillSetupTargetInfo> installableTargets =
SetupWizardWindow.GetFirstInstallableSkillTargets(
SetupWizardSkillsStepPresenter.GetFirstInstallableSkillTargets(
targets,
SkillsTarget.Claude,
groupSkillsUnderUnityCliLoop: true);
Expand All @@ -739,7 +739,7 @@ public void GetFirstInstallableSkillTargets_WhenSelectedTargetIsInstalled_Return
public void GetFirstInstallableSkillTargets_WhenSelectedTargetIsMissing_ReturnsMappedTarget()
{
List<SkillSetupTargetInfo> installableTargets =
SetupWizardWindow.GetFirstInstallableSkillTargets(
SetupWizardSkillsStepPresenter.GetFirstInstallableSkillTargets(
new List<SkillSetupTargetInfo>(),
SkillsTarget.Claude,
groupSkillsUnderUnityCliLoop: true);
Expand All @@ -761,7 +761,7 @@ public void GetSkillInstallStatusText_ReturnsExpectedLabel(
bool groupSkillsUnderUnityCliLoop,
string expectedLabel)
{
string label = SetupWizardWindow.GetSkillInstallStatusText(
string label = SetupWizardSkillsStepPresenter.GetSkillInstallStatusText(
installState,
hasDifferentLayoutSkills,
groupSkillsUnderUnityCliLoop);
Expand All @@ -777,7 +777,7 @@ public void GetInstallSkillsButtonText_ReturnsExpectedLabel(
bool hasOutdatedSkills,
string expectedLabel)
{
string label = SetupWizardWindow.GetInstallSkillsButtonText(
string label = SetupWizardSkillsStepPresenter.GetInstallSkillsButtonText(
isInstallingSkills,
hasOutdatedSkills);

Expand All @@ -794,7 +794,7 @@ public void GetSkillsButtonTextForSetupWizard_ReturnsExpectedLabel(
bool hasOutdatedSkills,
string expectedLabel)
{
string label = SetupWizardWindow.GetSkillsButtonTextForSetupWizard(
string label = SetupWizardSkillsStepPresenter.GetSkillsButtonTextForSetupWizard(
cliInstalled,
isInstallingSkills,
hasOutdatedSkills);
Expand Down Expand Up @@ -865,7 +865,7 @@ public void GetSkillInstallStatusClass_ReturnsExpectedClass(
bool groupSkillsUnderUnityCliLoop,
string expectedClass)
{
string className = SetupWizardWindow.GetSkillInstallStatusClass(
string className = SetupWizardSkillsStepPresenter.GetSkillInstallStatusClass(
installState,
hasDifferentLayoutSkills,
groupSkillsUnderUnityCliLoop);
Expand Down
Loading
Loading