Skip to content

chore: Share v3 migration skill target handling - #1609

Merged
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/share-v3-migration-task-run
Jul 8, 2026
Merged

hatayama merged 1 commit into
v3-betafrom
feature/hatayama/share-v3-migration-task-run

Conversation

@hatayama

@hatayama hatayama commented Jul 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keeps v3 migration skill install and removal result counting consistent across target loops.
  • Removes the repeated Task.Run target iteration skeleton from migration install/remove paths.

User Impact

  • Migration skill setup behavior is unchanged, but cancellation and target counting now flow through one implementation.

Changes

  • Added a shared private target runner for v3 migration skill operations.
  • Updated v3 migration install, full removal, and specific removal paths to pass only their per-target operation.
  • Added a multiple-target removal test that pins attempted/succeeded result counts.

Verification

  • dist/darwin-arm64/uloop compile --project-path "$(git rev-parse --show-toplevel)"
  • dist/darwin-arm64/uloop run-tests --project-path "$(git rev-parse --show-toplevel)" --test-mode EditMode --filter-type regex --filter-value "io\.github\.hatayama\.UnityCliLoop\.Tests\.Editor\.ToolSkillSynchronizerTests\.(InstallSpecificSkillFilesAtProjectRoot_WhenSingleSkillSourceIsProvided_InstallsOnlyThatSkill|GetV3MigrationSkillInstallStateAtProjectRoot_WhenSkillExistsInAlternateLayout_ReturnsInstalled|RemoveSpecificSkillFilesAtProjectRoot_WhenSkillExists_RemovesOnlyThatSkill|RemoveSpecificSkillFilesAtProjectRoot_WithMultipleTargets_ReportsAllTargetsSucceeded|RemoveV3MigrationSkillFilesAtProjectRoot_WhenSkillExistsInBothLayouts_RemovesBothLayouts)"
  • dist/darwin-arm64/uloop run-tests --project-path "$(git rev-parse --show-toplevel)" --test-mode EditMode --filter-type exact --filter-value "io.github.hatayama.UnityCliLoop.Tests.Editor.ToolSkillSynchronizerTests"
  • git diff --cached --check

Review in cubic

Extract the repeated target iteration Task.Run skeleton so v3 migration install and removal paths share result counting and cancellation observation.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23470ab7-fa5f-465c-b7e3-7888e331a14c

📥 Commits

Reviewing files that changed from the base of the PR and between d48998c and 8f243b8.

📒 Files selected for processing (2)
  • Assets/Tests/Editor/ToolSkillSynchronizerTests.cs
  • Packages/src/Editor/Infrastructure/SkillSetup/V3MigrationSkillInstaller.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/share-v3-migration-task-run

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@hatayama
hatayama merged commit c22bdd9 into v3-beta Jul 8, 2026
10 checks passed
@hatayama
hatayama deleted the feature/hatayama/share-v3-migration-task-run branch July 8, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant