Skip to content

chore: Keep skill target detection layout-aware - #1610

Merged
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/contain-layout-target-test-helper
Jul 8, 2026
Merged

hatayama merged 1 commit into
v3-betafrom
feature/hatayama/contain-layout-target-test-helper

Conversation

@hatayama

@hatayama hatayama commented Jul 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep skill target detection maintenance paths layout-aware by removing the layout-agnostic detector entry that only tests used.
  • Preserve the existing setup coverage by making tests choose flat or grouped layout detection explicitly.

User Impact

  • No runtime behavior changes are intended.
  • Future setup maintenance is less likely to call a test-only detector that ignores the selected skill layout.

Changes

  • Removed the unused production-only-for-tests across-layout skill target detector entry.
  • Updated affected Editor tests to call the layout-state detector with explicit flat or grouped layout settings.

Verification

  • dist/darwin-arm64/uloop clear-console --project-path "/Users/a12115/ghq/hatayama/unity-cli-loop2"
  • dist/darwin-arm64/uloop compile --project-path "/Users/a12115/ghq/hatayama/unity-cli-loop2" (0 errors, 0 warnings)
  • dist/darwin-arm64/uloop run-tests --project-path "/Users/a12115/ghq/hatayama/unity-cli-loop2" --test-mode EditMode --filter-type regex --filter-value "^io.github.hatayama.UnityCliLoop.Tests.Editor.ToolSkillSynchronizerTests." (51 passed)

Review in cubic

Delete the production detector entry that only tests used so runtime code exposes only the layout-aware target detection path. Update the affected tests to call the current layout-state detector explicitly for flat or grouped installs.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9ba8ec56-eb23-4352-aca8-ca4a86b685e2

📥 Commits

Reviewing files that changed from the base of the PR and between c22bdd9 and a7ed1d3.

📒 Files selected for processing (2)
  • Assets/Tests/Editor/ToolSkillSynchronizerTests.cs
  • Packages/src/Editor/Infrastructure/SkillSetup/SkillTargetDetector.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/contain-layout-target-test-helper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@hatayama
hatayama merged commit fd0b78f into v3-beta Jul 8, 2026
10 checks passed
@hatayama
hatayama deleted the feature/hatayama/contain-layout-target-test-helper branch July 8, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant