chore: Simplify full sync skill cleanup

[hatayama]

Summary

• Simplify full skill synchronization by removing a prune pass that no longer had an effective deletion target.
• Keep cleanup behavior covered with a test that disabled skills are removed from both skill layouts during full sync.

User Impact

• No user-facing behavior change is intended.
• Setup maintenance becomes easier to reason about because disabled/deprecated cleanup is handled in one explicit path before enabled skills are installed.

Changes

• Removed the full-sync unexpected-directory prune branch from skill target installation.
• Removed the now-unused installed skill directory name enumerator created only for that prune path.
• Added Editor coverage for disabled skill cleanup across flat and grouped layouts.

Verification

• dist/darwin-arm64/uloop clear-console --project-path "/Users/a12115/ghq/hatayama/unity-cli-loop2"
• dist/darwin-arm64/uloop compile --project-path "/Users/a12115/ghq/hatayama/unity-cli-loop2" (0 errors, 0 warnings)
• dist/darwin-arm64/uloop run-tests --project-path "/Users/a12115/ghq/hatayama/unity-cli-loop2" --test-mode EditMode --filter-type regex --filter-value "^io.github.hatayama.UnityCliLoop.Tests.Editor.ToolSkillSynchronizerTests." (52 passed)
• git diff --check
• Repository search confirmed no remaining references to DeleteUnexpectedInstalledSkillDirectories, GetManagedSkillNames, or EnumerateInstalledSkillDirectoryNamesForLayout

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ce29c433-316f-4e4a-8a26-6dba2176cb5a

📥 Commits

Reviewing files that changed from the base of the PR and between fd0b78f and 2ed565c.

📒 Files selected for processing (3)

• Assets/Tests/Editor/ToolSkillSynchronizerTests.cs
• Packages/src/Editor/Infrastructure/SkillSetup/SkillInstallLayout.cs
• Packages/src/Editor/Infrastructure/SkillSetup/SkillTargetInstaller.cs

💤 Files with no reviewable changes (2)

• Packages/src/Editor/Infrastructure/SkillSetup/SkillInstallLayout.cs
• Packages/src/Editor/Infrastructure/SkillSetup/SkillTargetInstaller.cs

---

📝 Walkthrough

Walkthrough

FullSync no longer deletes "unexpected" installed skill directories; SkillTargetInstaller removes the computation and cleanup logic (GetManagedSkillNames, DeleteUnexpectedInstalledSkillDirectories). SkillInstallLayout replaces its directory-name enumeration helper with a single-path lookup helper. A new test verifies disabled skills are removed from both flat and grouped layouts.

Changes

FullSync Cleanup Removal

Layer / File(s)	Summary
Layout helper simplification Packages/src/Editor/Infrastructure/SkillSetup/SkillInstallLayout.cs	Replaces EnumerateInstalledSkillDirectoryNamesForLayout with GetInstalledSkillDirectoryPathForLayout, which delegates to the existing path-lookup method.
Remove unexpected-directory deletion from FullSync Packages/src/Editor/Infrastructure/SkillSetup/SkillTargetInstaller.cs	Deletes the FullSync branch and helper methods that computed managed skill names and removed unexpected installed directories; removes the unused using System; directive.
Test coverage for dual-layout removal Assets/Tests/Editor/ToolSkillSynchronizerTests.cs	Adds a test confirming InstallSkillFilesAtProjectRoot removes both flat and grouped layout directories for a disabled skill while keeping enabled skills installed.

Estimated code review effort: 2 (Simple) | ~12 minutes

Possibly related PRs

• hatayama/unity-cli-loop#980: Both PRs modify skill layout/sync cleanup logic to stop deleting unexpected installed skill directories and update related tests.
• hatayama/unity-cli-loop#1588: Both PRs refactor the same FullSync cleanup and layout helper internals in SkillTargetInstaller/SkillInstallLayout.
• hatayama/unity-cli-loop#1589: Both PRs modify the same FullSync cleanup logic in SkillTargetInstaller.cs around deleting unexpected installed skill directories.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: simplifying full sync skill cleanup.
Description check	✅ Passed	The description is directly related to the code changes and test coverage in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/hatayama/verify-full-sync-prune

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 3 files

_{Re-trigger cubic}