chore: Simplify native CLI uninstall completion handling

[hatayama]

Summary

• Preserve native CLI uninstall behavior while separating cleanup polling from installer orchestration and process execution.
• Keep existing public installer and setup APIs unchanged.

User Impact

• No user-visible behavior change.
• Uninstall completion, cancellation, timeout timing, and failure messages remain unchanged.

Changes

• Move uninstall target and Windows User PATH polling into NativeCliUninstallCompletionWaiter.
• Move the uninstall completion timeout constant with the waiter.
• Keep polling cadence supplied by NativeCliInstaller, allowing process wait timing to be separated in the next refactor.
• Update the installer and seven existing test references to use the waiter directly without compatibility wrappers.
• Keep the test-only target-removal helper unchanged for this move-only PR; its deletion eligibility is recorded as R2-30.

Verification

• Unity compile: 0 errors, 0 warnings
• NativeCliInstallerTests: 33 passed
• StaticFacadeStateGuardTests: 20 passed
• No waiter-to-installer or waiter-to-command-builder reverse references
• No IPC or protocol changes

Review Follow-up

• cubic observed that production passes requireUserPathRemoval: false. This is intentional behavior from PR fix: Unity package no longer includes development CLI binaries #1250, where the package-local development CLI was removed and the installed launcher became responsible for uninstall and persisted User PATH cleanup.
• The remaining test-only User PATH polling chain is recorded under R2-30 for dead-code scanning and removal after this move-only PR.

[coderabbitai]

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fe424362-af6c-4908-a79e-25a367154450

📥 Commits

Reviewing files that changed from the base of the PR and between 345c027 and 048ebe6.

⛔ Files ignored due to path filters (1)

• Packages/src/Editor/Infrastructure/CLI/NativeCliUninstallCompletionWaiter.cs.meta is excluded by none and included by none

📒 Files selected for processing (3)

• Assets/Tests/Editor/NativeCliInstallerTests.cs
• Packages/src/Editor/Infrastructure/CLI/NativeCliInstaller.cs
• Packages/src/Editor/Infrastructure/CLI/NativeCliUninstallCompletionWaiter.cs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/hatayama/extract-native-cli-uninstall-waiter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

All reported issues were addressed across 4 files

_{You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>